Plugin produces too much log at INFO level while analyzing log messages

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1
  • Component/s: Report / Mojo
  • Labels:
    None
  • Environment:
    scmchangelog 1.0

Description

While analyzing scm log messages scmchangelog plug-in unnecessarily produces a log message per scm log entry at what I think is too high, INFO, level. These log messages maybe would be interesting while debugging, but not in normal use of plug-in. Since Java Logging API is being used, I propose these messages to be logged at most at FINE level. Attached is a patch which makes necessary changes.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Side note: Maven plugins should not use JDK logging but the mojo/plexus logger injected by Maven. Otherwise, plugins bypass the logging configuration of Maven.

Show
Benjamin Bentmann added a comment - Side note: Maven plugins should not use JDK logging but the mojo/plexus logger injected by Maven. Otherwise, plugins bypass the logging configuration of Maven.
Hide
Permalink
Emmanuel Hugonnet added a comment -

I do agree but how do you get a logger when unit testing ?
I will remove JDK logging.

Show
Emmanuel Hugonnet added a comment - I do agree but how do you get a logger when unit testing ? I will remove JDK logging.
Hide
Permalink
Emmanuel Hugonnet added a comment -

Fixed with revision 7975.
Traces set to debug, and using Maven logger.

Show
Emmanuel Hugonnet added a comment - Fixed with revision 7975. Traces set to debug, and using Maven logger.
Hide
Permalink
Benjamin Bentmann added a comment -

how do you get a logger when unit testing ?

The maven-plugin-api provides a SystemStreamLog. That can either be injected into the component under test by the test controller or the component itself can return this if no other logger has been set before (c.f. impl of AbstractMojo.getLog()).

Show
Benjamin Bentmann added a comment -
how do you get a logger when unit testing ?
The maven-plugin-api provides a SystemStreamLog. That can either be injected into the component under test by the test controller or the component itself can return this if no other logger has been set before (c.f. impl of AbstractMojo.getLog()).
Hide
Permalink
Emmanuel Hugonnet added a comment -

Thank you Benjamin, the logging problem was caused by the SCM API which uses its own kind of logger (ScmLogger) and not the maven one (you need to go the the maven-scm-plugin to have one implementation). I didn't understand why I was getting the report traces but not my scm commands traces. I should have been more carefull but I did the quick hack and used the JDK Logging API.

Show
Emmanuel Hugonnet added a comment - Thank you Benjamin, the logging problem was caused by the SCM API which uses its own kind of logger (ScmLogger) and not the maven one (you need to go the the maven-scm-plugin to have one implementation). I didn't understand why I was getting the report traces but not my scm commands traces. I should have been more carefull but I did the quick hack and used the JDK Logging API.

People

  • Assignee:
    Emmanuel Hugonnet
    Reporter:
    Stevo Slavic
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: