Maven Sandbox
  1. Maven Sandbox
  2. MSANDBOX-51

Rewrite Plexus Utils classes at the ASF from scratch

    Details

    • Type: New Feature New Feature
    • Status: Open Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      3

      Description

      plexus-utils are 85% written by ASF committers, but we still don't have a IP cleared history.
      For cleaning this up we aim to rewrite those classes from scratch in ASF maven sandbox.

      The strategy is the following:

      1. create unit tests for the existing plexus classes
      2. create a new implementation from scratch
      3. the new implementation must be a binary API compatible drop-in replacement

      1. diff.txt
        3 kB
        James Saunders
      2. plexus-utils-tck.patch
        3 kB
        Michael Nitschke
      3. plexus-utils-tck.patch
        3 kB
        James Saunders

        Activity

        Hide
        Brett Porter added a comment -

        right, if there are originals in the ASF SVN we can certainly copy that across (probably with history) - but I'm suggesting it should be an exceptional case. I don't think Maven wants to take on maintaining any of this code unless we've exhausted any other options.

        Are there any other cases at the moment that are copied / rewritten instead of bridged to existing code?

        Show
        Brett Porter added a comment - right, if there are originals in the ASF SVN we can certainly copy that across (probably with history) - but I'm suggesting it should be an exceptional case. I don't think Maven wants to take on maintaining any of this code unless we've exhausted any other options. Are there any other cases at the moment that are copied / rewritten instead of bridged to existing code?
        Hide
        Mark Struberg added a comment -

        I think I've touched 5 classes yet and 4 of them are clearly forked from ASF projects and still 90% of that code remaining.

        Check this locations for obvious hits:

        Of coure, sometimes you also have to grab back into the CVS archive. A good indicator is the @author tag. Commons dropped that around 2004, but plexus-utils most times still have them. An example: All classes with @author Stefan Bodewig are most certainly 1:1 forks from Ant.

        Show
        Mark Struberg added a comment - I think I've touched 5 classes yet and 4 of them are clearly forked from ASF projects and still 90% of that code remaining. Check this locations for obvious hits: http://maven.apache.org/maven-1.x/xref/org/apache/maven/util/ http://svn.apache.org/repos/asf/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ http://svn.apache.org/repos/asf/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/condition/ http://svn.apache.org/repos/asf/commons/proper/exec/trunk/src/main/java/org/apache/commons/exec/ Of coure, sometimes you also have to grab back into the CVS archive. A good indicator is the @author tag. Commons dropped that around 2004, but plexus-utils most times still have them. An example: All classes with @author Stefan Bodewig are most certainly 1:1 forks from Ant.
        Hide
        James Saunders added a comment - - edited

        Hi Mark,

        I have created a test for the SelectorUtils class.
        I enclose the svn diff as requested.
        Also enclosed as patch created in eclipse.

        Show
        James Saunders added a comment - - edited Hi Mark, I have created a test for the SelectorUtils class. I enclose the svn diff as requested. Also enclosed as patch created in eclipse.
        Hide
        Michael Nitschke added a comment - - edited

        I agree
        with the submitted patch.

        Mike/Michael

        Show
        Michael Nitschke added a comment - - edited I agree with the submitted patch. Mike/Michael
        Hide
        Mark Struberg added a comment -

        patch applied, thanks James and Michael!

        Show
        Mark Struberg added a comment - patch applied, thanks James and Michael!

          People

          • Assignee:
            Unassigned
            Reporter:
            Mark Struberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: