Mojo RPM Plugin

Specify individual files (when appropriate) in the generated .spec file.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-beta-2
  • Component/s: rpm
  • Labels:
    None
  • Number of attachments :
    1

Description

When generating the spec file from the mappings, the assumption is made that everything in the mapping destination should have the attributes (filemode, config) defined for the mapping. It should be possible to have multiple mappings point to the same destination (with different sources) with different attributes.

For this to actually work, it is important that the buildroot is populated prior to generating the spec file.

Issue Links

This issue duplicates:
MRPM-14 Specifying <directory> of a pre-exising system directory results in an RPM which can't be installed due to conflicts Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Okken added a comment -

Here is a patch. It includes fixes for MOJO-1249, MOJO-1250 and MOJO-1251.

Show
Brett Okken added a comment - Here is a patch. It includes fixes for MOJO-1249, MOJO-1250 and MOJO-1251.
Hide
Permalink
Brett Okken added a comment -

This patch adds a fix for MOJO-931 as well.

Under the <mapping> element you can add an optional element: <includeDir>boolean</includeDir>. By default it's true. If false, the directory specified in the mapping is not included.

Show
Brett Okken added a comment - This patch adds a fix for MOJO-931 as well. Under the <mapping> element you can add an optional element: <includeDir>boolean</includeDir>. By default it's true. If false, the directory specified in the mapping is not included.
Hide
Permalink
Brett Okken added a comment - - edited

Adding patch which also includes the site documentation and removes the formatting changes from RPMMojo.

This patch includes fixes for MOJO-931, MOJO-1202, MOJO-1249, MOJO-1250, and MOJO-1251.

Show
Brett Okken added a comment - - edited Adding patch which also includes the site documentation and removes the formatting changes from RPMMojo. This patch includes fixes for MOJO-931, MOJO-1202, MOJO-1249, MOJO-1250, and MOJO-1251.
Hide
Permalink
Carlos Sanchez added a comment -

IIUC this is a duplicate of MOJO-931
if not please reopen with explanation, and please provide patches just for the issue in question so they are easier to review and apply

Show
Carlos Sanchez added a comment - IIUC this is a duplicate of MOJO-931 if not please reopen with explanation, and please provide patches just for the issue in question so they are easier to review and apply
Hide
Permalink
Brett Okken added a comment -

While this is similar to MOJO-931, it is not a duplicate.

Your changes allow the "source" to refer to an individual file, however it is still assuming that only one mapping ever exists for a directory. It should be possible to have multiple mappings for the same source location (identifying different files through includes/excludes), so that the files can be given different attributes (such as having some files marked as configuration).

Show
Brett Okken added a comment - While this is similar to MOJO-931, it is not a duplicate. Your changes allow the "source" to refer to an individual file, however it is still assuming that only one mapping ever exists for a directory. It should be possible to have multiple mappings for the same source location (identifying different files through includes/excludes), so that the files can be given different attributes (such as having some files marked as configuration).
Hide
Permalink
Brett Okken added a comment -

here is a patch based on latest 2.0-beta-2-SNAPSHOT (rev 8670).

Show
Brett Okken added a comment - here is a patch based on latest 2.0-beta-2-SNAPSHOT (rev 8670).
Hide
Permalink
Brett Okken added a comment -

I missed the possibility of the source location being a file - that is fixed here.

Show
Brett Okken added a comment - I missed the possibility of the source location being a file - that is fixed here.
Hide
Permalink
Carlos Sanchez added a comment -

Applied patch

Show
Carlos Sanchez added a comment - Applied patch

People

Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.