Mojo RPM Plugin

Various solutions for: MOJO-929, MOJO-972, MOJO-931

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: rpm
  • Labels:
    None
  • Number of attachments :
    8

Description

I have checked out the source code and made a number of modifications (plan to do some more in the future for some other needs). I currently do not have check in privileges, hence this improvement issue.

These changes fix several issues listed here: http://jira.codehaus.org/browse/MOJO-929, http://jira.codehaus.org/browse/MOJO-972, http://jira.codehaus.org/browse/MOJO-931. I will add comments to each issue for specific information on each fix.

Attached is a zip that contains an updated jar (version: 2.0-beta-8-CR) and the modified source files (not patches).

Issue Links

This issue is superceded by:
MRPM-14 Specifying <directory> of a pre-exising system directory results in an RPM which can't be installed due to conflicts Minor Closed
MRPM-16 the maven-rpm-plugin should allow users to specify the target architecure. needsarch is insufficient. Critical Closed
MRPM-32 Would be nice with more graceful handling of the release strings used by the maven release plugin Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

this patch is impossible to apply, the source format has been changed so a diff doesnt allow to review what has been changed. Please provied a diff/patch with only the changes required

Show
Carlos Sanchez added a comment - this patch is impossible to apply, the source format has been changed so a diff doesnt allow to review what has been changed. Please provied a diff/patch with only the changes required
Hide
Permalink
Chris Ryan added a comment - - edited

Unfortunately, these files have been "formatted", so there are a number of irrelevant changes in each patch file.

Source.java.patch changes relate to targetArch property.
Mapping.java.patch changes relate to includeDir feature.
RPMMojo.java.patch uses those changes plus fix for the '-' in version. Most relevant changes relate to the includeDir feature to build "extra" Mapping entries correctly.

Show
Chris Ryan added a comment - - edited Unfortunately, these files have been "formatted", so there are a number of irrelevant changes in each patch file. Source.java.patch changes relate to targetArch property. Mapping.java.patch changes relate to includeDir feature. RPMMojo.java.patch uses those changes plus fix for the '-' in version. Most relevant changes relate to the includeDir feature to build "extra" Mapping entries correctly.
Hide
Permalink
Chris Ryan added a comment -

The files *.diff.patch are alternate differences where I compared my formatted files with formatted files from a clean checkout. They might be more useful understanding the differences involved.

Show
Chris Ryan added a comment - The files *.diff.patch are alternate differences where I compared my formatted files with formatted files from a clean checkout. They might be more useful understanding the differences involved.
Hide
Permalink
Carlos Sanchez added a comment -

Updated patch against latest version, removed all unnecessary differences and already fixed issues (ie. license)
Please review and submit patches in each issue, instead of a big patch for all so they can be independently reviewed

Show
Carlos Sanchez added a comment - Updated patch against latest version, removed all unnecessary differences and already fixed issues (ie. license) Please review and submit patches in each issue, instead of a big patch for all so they can be independently reviewed
Hide
Permalink
Brett Okken added a comment -

The three issues this provided fixes for have been closed.

Show
Brett Okken added a comment - The three issues this provided fixes for have been closed.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.