jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Mojo RPM Plugin
  • MRPM-16

the maven-rpm-plugin should allow users to specify the target architecure. needsarch is insufficient.

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-beta-2
  • Component/s: rpm
  • Labels:
    None

Description

the maven-rpm-plugin should allow users to specify the target architecure. needsarch is insufficient.

Issue Links

supercedes

Improvement - An improvement or enhancement to an existing feature or task. MRPM-22 Various solutions for: MOJO-929, MOJO-972, MOJO-931

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Chris Ryan added a comment - 18/May/08 7:41 PM

I have a fix for this (http://jira.codehaus.org/browse/MOJO-1125).

Under <configuaration> you can add a <targetArch> element:

<configuration>
...
<targetArch>x86_64</targetArch>
...

Also, each source element can be filtered by arch as well, like so:

...
<source>
<location>src/main/native/x86_64</location>
<targetArch>x86_64</targetArch>
</source>
<source>
<location>src/main/native/i586</location>
<targetArch>i586</targetArch>
</source>
...

This can be useful if you set a property for your targetArch (e.g. <targetArch>${target_arch}</targetArch>) and then pass the value in during build time.

Show
Chris Ryan added a comment - 18/May/08 7:41 PM I have a fix for this (http://jira.codehaus.org/browse/MOJO-1125). Under <configuaration> you can add a <targetArch> element: <configuration> ... <targetArch>x86_64</targetArch> ... Also, each source element can be filtered by arch as well, like so: ... <source> <location>src/main/native/x86_64</location> <targetArch>x86_64</targetArch> </source> <source> <location>src/main/native/i586</location> <targetArch>i586</targetArch> </source> ... This can be useful if you set a property for your targetArch (e.g. <targetArch>${target_arch}</targetArch>) and then pass the value in during build time.
Hide
Permalink
Brett Okken added a comment - 23/Jan/09 7:41 AM

In order to be a bit more passive, I suggest that we change the behavior of needarch to be more flexible.

If we change needarch to be a string, if the value is "true" or "false" (also note that no value would still be "noarch"), it can work exactly as it does today. However, if the value is anything else (such as "x86_64"), that will be set as the target architecture. (This is similar to how MOJO-1201 was handled).

The idea of filtering the source(s) is interesting. I would assume that a source with no "targetArch" value would always be included. If the target architecture of the rpm is "noarch", should every source match, or only those with no "targetArch"?

Show
Brett Okken added a comment - 23/Jan/09 7:41 AM In order to be a bit more passive, I suggest that we change the behavior of needarch to be more flexible. If we change needarch to be a string, if the value is "true" or "false" (also note that no value would still be "noarch"), it can work exactly as it does today. However, if the value is anything else (such as "x86_64"), that will be set as the target architecture. (This is similar to how MOJO-1201 was handled). The idea of filtering the source(s) is interesting. I would assume that a source with no "targetArch" value would always be included. If the target architecture of the rpm is "noarch", should every source match, or only those with no "targetArch"?
Hide
Permalink
Brett Okken added a comment - 26/Jan/09 7:43 AM

Fixed in 2.0-beta-2-SNAPSHOT

Show
Brett Okken added a comment - 26/Jan/09 7:43 AM Fixed in 2.0-beta-2-SNAPSHOT

People

  • Assignee:
    Brett Okken
    Reporter:
    Brandon Enochs
Vote (1)
Watch (2)

Dates

  • Created:
    13/Dec/07 2:30 PM
    Updated:
    12/Feb/10 8:06 AM
    Resolved:
    26/Jan/09 7:43 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.