Archiva

Unable to use archiva as http source with maven-stage-plugin

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.1.1
  • Component/s: browser
  • Labels:
    None
  • Environment:
    linux, windows
  • Number of attachments :
    1

Description

great - feel free to file a bug in Archiva too - though it's not
incorrect, it'd be better without it and we can probably fix this more
easily than getting the updated version to the maven client.

  • Hide quoted text -

2008/7/26 Dan Tran <dantran@gmail.com>:
> I look the html contents for repo1.apache.org/maven2 and the archiva
> at http://archiva.openqa.org/repository/releases/
>
> the repo1 shows
> <img src="/icons/folder.gif" alt="[DIR]"> <a href="abbot/">abbot/</a>
> 31-Oct-2005 23:09 -
>
> the archiva shows
>
> <li><a href="./org/">org/</li>
>
>
> So the problem area seems to be at the extra "./" at archiva.
>
> will write up a test case for this.
>
> -D
>
> On Fri, Jul 25, 2008 at 10:01 PM, Dan Tran <dantran@gmail.com> wrote:
>> sure, i will look into it
>>
>> thanks
>>
>> -D
>>
>> On Fri, Jul 25, 2008 at 9:57 PM, Brett Porter <brett.porter@gmail.com> wrote:
>>> Yes, that'd be the place to look (it's just that it's on the end of
>>> the stage plugin where it is occurring
>>>
>>> 2008/7/26 Dan Tran <dantran@gmail.com>:
>>>> you mean http wagon?
>>>>
>>>> -D
>>>>
>>>> On Fri, Jul 25, 2008 at 9:45 PM, Brett Porter <brett.porter@gmail.com> wrote:
>>>>> That would be an issue with the stage plugin I think - the HTML on
>>>>> Archiva looks fine to me.
>>>>>
>>>>> 2008/7/26 Dan Tran <dantran@gmail.com>:
>>>>>> From the other post, is it is same error for both 1.1( mine) and 1.0.2
>>>>>> (other user) archiva. When the stage plugin asks for a list
>>>>>> of files available at source repo ( ie the staging repo), it gets a
>>>>>> list of one item ( a space )
>>>>>>
>>>>>> on windows, the error is access deny, and unix it complains about cant
>>>>>> not create directory.
>>>>>>
>>>>>> -D
>>>>>>
>>>>>> On Fri, Jul 25, 2008 at 9:33 PM, Brett Porter <brett.porter@gmail.com> wrote:
>>>>>>> The stage plugin doesn't support http targets, that's correct.
>>>>>>>
>>>>>>> There was previously some bugs in the HTML rendering, but they should
>>>>>>> be fine under 1.1. Is that what you are seeing?
>>>>>>>
>>>>>>> Cheers,
>>>>>>> Brett
>>>>>>>
>>>>>>> 2008/7/26 Dan Tran <dantran@gmail.com>:
>>>>>>>> Dont think it is a bug, but worth to ask.
>>>>>>>>
>>>>>>>> see http://www.nabble.com/Re%3A-error-plugin-stage-to16634443.html
>>>>>>>>
>>>>>>>> I am using archiva 1.1 on linux
>>>>>>>>
>>>>>>>> -D
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> –
>>>>>>> Brett Porter
>>>>>>> Blog: http://blogs.exist.com/bporter/
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> –
>>>>> Brett Porter
>>>>> Blog: http://blogs.exist.com/bporter/
>>>>>
>>>>
>>>
>>>
>>>
>>> –
>>> Brett Porter
>>> Blog: http://blogs.exist.com/bporter/
>>>
>>
>

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Tran added a comment -

my suspicion is correct.

I took the contents of a archiva page at archiva.openqa.org and feed it to the httpwagon html parser test at
http://svn.apache.org/repos/asf/maven/wagon/trunk/wagon-providers/wagon-http-shared/src/test/java/org/apache/maven/wagon/shared/http/HtmlFileListParserTest.java

The test fails since it detect no element. However when taken out the prefix "./", it is able to parse the content

note, my last note mentions about a list of one item ( a space, it is actually an empty string) is because the stage plugin
appends that item to the list when it is empty.

So who should fix this? wagon or archiva? not much wagon can do since cyberneko parser not able to detect the link.

Show
Dan Tran added a comment - my suspicion is correct. I took the contents of a archiva page at archiva.openqa.org and feed it to the httpwagon html parser test at http://svn.apache.org/repos/asf/maven/wagon/trunk/wagon-providers/wagon-http-shared/src/test/java/org/apache/maven/wagon/shared/http/HtmlFileListParserTest.java The test fails since it detect no element. However when taken out the prefix "./", it is able to parse the content note, my last note mentions about a list of one item ( a space, it is actually an empty string) is because the stage plugin appends that item to the list when it is empty. So who should fix this? wagon or archiva? not much wagon can do since cyberneko parser not able to detect the link.
Hide
Permalink
Dan Tran added a comment -

I am able to reproduce the probem as stated using the wagon test, will need to further investigation.

Show
Dan Tran added a comment - I am able to reproduce the probem as stated using the wagon test, will need to further investigation.
Hide
Permalink
Brett Porter added a comment -

I think we can remove the leading ./ to help out, though the bug should be filed with wagon (if you could attach a patch that contains the failing test, that'd be a good starting point).

Show
Brett Porter added a comment - I think we can remove the leading ./ to help out, though the bug should be filed with wagon (if you could attach a patch that contains the failing test, that'd be a good starting point).
Hide
Permalink
Dan Tran added a comment -

more info.

I am able to produce the problem by feeding the content of the root page to wagon-beta-2, however
the with wagon-1.0-beta-3. It is ok. I guess the new html parser in beta-3 does a better job.

However when build staging plugin with wagon beta-3, the staging plugin crashes with

java.lang.ArrayIndexOutOfBoundsException: -1
at org.cyberneko.html.HTMLTagBalancer$InfoStack.pop(HTMLTagBalancer.java:1262)
at org.cyberneko.html.HTMLTagBalancer.startElement(HTMLTagBalancer.java:669)
at org.cyberneko.html.HTMLScanner$ContentScanner.scanStartElement

oh well, I need to to further debugging.

I am looking at both ends to:

make archiva brower to match the apache browser, this way with it will work with wagon-beta-2

or

fix the AIOE error with wagon-beta-3.

Show
Dan Tran added a comment - more info. I am able to produce the problem by feeding the content of the root page to wagon-beta-2, however the with wagon-1.0-beta-3. It is ok. I guess the new html parser in beta-3 does a better job. However when build staging plugin with wagon beta-3, the staging plugin crashes with java.lang.ArrayIndexOutOfBoundsException: -1 at org.cyberneko.html.HTMLTagBalancer$InfoStack.pop(HTMLTagBalancer.java:1262) at org.cyberneko.html.HTMLTagBalancer.startElement(HTMLTagBalancer.java:669) at org.cyberneko.html.HTMLScanner$ContentScanner.scanStartElement oh well, I need to to further debugging. I am looking at both ends to: make archiva brower to match the apache browser, this way with it will work with wagon-beta-2 or fix the AIOE error with wagon-beta-3.
Hide
Permalink
Brett Porter added a comment -

yep, I agree both should be done

Show
Brett Porter added a comment - yep, I agree both should be done
Hide
Permalink
Dan Tran added a comment -

I think i found the root cause of AIOE see MRM-893 for details.

Also, I think I can also get staging-plugin with wagon-beta-2 to work with some help from archiva to
remove the prefix "./". See attached patch. ( hope is ok since I work again the 1.1 tag )

Show
Dan Tran added a comment - I think i found the root cause of AIOE see MRM-893 for details. Also, I think I can also get staging-plugin with wagon-beta-2 to work with some help from archiva to remove the prefix "./". See attached patch. ( hope is ok since I work again the 1.1 tag )
Hide
Permalink
Brett Porter added a comment -

applied, thanks!

Show
Brett Porter added a comment - applied, thanks!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.