Use a "work" directory for the repo path (e.g. if the repo definition root is mydir/ then put the actually repo under /mydir/repository)

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.0, 1.0.1, 1.0.2, 1.1
  • Fix Version/s: None
  • Component/s: Design, repository interface
  • Labels:
    None

Description

See discussion here: MRM-789

Note:
Review the pros and cons of this setup.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MRM-789 Archiva may delete you app server installation

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

I don't think this is wise, you lose the flexibility of specifying what you actually want. It also doesn't help if "repository" under the root is actually an important directory.

The default configuration should not point at a dangerous location. If someone explicitly creates a repo in a bad spot, and sets the permissions to be able to be deleted, and hits delete, and opts to delete the contents beyond the warning... they're probably pretty intent on deleting it

Show
Brett Porter added a comment - I don't think this is wise, you lose the flexibility of specifying what you actually want. It also doesn't help if "repository" under the root is actually an important directory. The default configuration should not point at a dangerous location. If someone explicitly creates a repo in a bad spot, and sets the permissions to be able to be deleted, and hits delete, and opts to delete the contents beyond the warning... they're probably pretty intent on deleting it
Hide
Permalink
Maria Odea Ching added a comment -

"The default configuration should not point at a dangerous location. If someone explicitly creates a repo in a bad spot, and sets the permissions to be able to be deleted, and hits delete, and opts to delete the contents beyond the warning... they're probably pretty intent on deleting it "

Yeah, this was what I've been thinking too.. and that is why we have the 'Confirm Delete' page

Show
Maria Odea Ching added a comment - "The default configuration should not point at a dangerous location. If someone explicitly creates a repo in a bad spot, and sets the permissions to be able to be deleted, and hits delete, and opts to delete the contents beyond the warning... they're probably pretty intent on deleting it " Yeah, this was what I've been thinking too.. and that is why we have the 'Confirm Delete' page
Hide
Permalink
Wendy Smoak added a comment -

Also not in favor-- the directory I configure should be the directory that gets used, with nothing appended.

Has anyone confirmed the original issue, which seems to be not so much that the Tomcat install got deleted, but that the repository location defaulted to the same directory as the Tomcat location?

Show
Wendy Smoak added a comment - Also not in favor-- the directory I configure should be the directory that gets used, with nothing appended. Has anyone confirmed the original issue, which seems to be not so much that the Tomcat install got deleted, but that the repository location defaulted to the same directory as the Tomcat location?
Hide
Permalink
Maria Odea Ching added a comment -

Yep, I verified the original issue both in 1.0.2 & trunk but the repo location didn't default to the Tomcat location for me. I tried setting appserver.base & appserver.home to ${catalina.home}, and the data/repositories/internal were just appended to the value of appserver.base/appserver.home. And when I didn't set these variables, the repo location defaulted to /data/repositories/internal.

Show
Maria Odea Ching added a comment - Yep, I verified the original issue both in 1.0.2 & trunk but the repo location didn't default to the Tomcat location for me. I tried setting appserver.base & appserver.home to ${catalina.home}, and the data/repositories/internal were just appended to the value of appserver.base/appserver.home. And when I didn't set these variables, the repo location defaulted to /data/repositories/internal.
Hide
Permalink
Brett Porter added a comment -

I think we've confirmed the default is sensible and not harmful and put enough prevention in place to help out.

Show
Brett Porter added a comment - I think we've confirmed the default is sensible and not harmful and put enough prevention in place to help out.

People

  • Assignee:
    Brett Porter
    Reporter:
    Maria Odea Ching
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: