Archiva

Artifact information screen should indicate the name of repository in which the artifact resides

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1.1
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

Click Browse and click any artifact. It would be nice if the repository location of the artifact is also displayed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Gwen Harold Autencio added a comment -

Attached patch that would display the repository of artifact when user goes artifact information.

Show
Gwen Harold Autencio added a comment - Attached patch that would display the repository of artifact when user goes artifact information.
Hide
Permalink
Maria Odea Ching added a comment -

Thanks for the patch Gwen! Could you also provide tests for the fix?

Show
Maria Odea Ching added a comment - Thanks for the patch Gwen! Could you also provide tests for the fix?
Hide
Permalink
Gwen Harold Autencio added a comment -

Created getRepositoryId() in RepositoryBrowsing to get the repositoryId of the artifact

Show
Gwen Harold Autencio added a comment - Created getRepositoryId() in RepositoryBrowsing to get the repositoryId of the artifact
Hide
Permalink
Maria Odea Ching added a comment -

Applied some parts of the patch in trunk -r679767.

From the patch, I only applied the changes from the following files as only these are necessary for the fix:

  • archiva-modules/archiva-database/src/main/java/org/apache/maven/archiva/database/browsing/DefaultRepositoryBrowsing.java
  • archiva-modules/archiva-database/src/main/java/org/apache/maven/archiva/database/browsing/RepositoryBrowsing.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/BrowseAction.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ShowArtifactAction.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/include/artifactInfo.jspf

And in the patch for ShowArtifactAction, I changed the following line from

setRepositoryId(repoBrowsing.getRepositoryId( getPrincipal(), getObservableRepos(), groupId, artifactId, version ));

to

this.repositoryId = repoBrowsing.getRepositoryId( getPrincipal(), getObservableRepos(), groupId, artifactId, version );

Show
Maria Odea Ching added a comment - Applied some parts of the patch in trunk -r679767. From the patch, I only applied the changes from the following files as only these are necessary for the fix:
  • archiva-modules/archiva-database/src/main/java/org/apache/maven/archiva/database/browsing/DefaultRepositoryBrowsing.java
  • archiva-modules/archiva-database/src/main/java/org/apache/maven/archiva/database/browsing/RepositoryBrowsing.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/BrowseAction.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ShowArtifactAction.java
  • archiva-modules/archiva-web/archiva-webapp/src/main/webapp/WEB-INF/jsp/include/artifactInfo.jspf
And in the patch for ShowArtifactAction, I changed the following line from setRepositoryId(repoBrowsing.getRepositoryId( getPrincipal(), getObservableRepos(), groupId, artifactId, version )); to this.repositoryId = repoBrowsing.getRepositoryId( getPrincipal(), getObservableRepos(), groupId, artifactId, version );

People

Vote (3)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.