Archiva

Support inclusion of pom file when deploying an artifact via the web upload form

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.1
  • Component/s: Web Interface
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently the web upload form only supports pom generation when uploading M2 artifacts.

Issue Links

This issue is related to:
MRM-785 No message is displayed after a successful artifact upload Minor Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wendy Smoak added a comment -

Initial work done in r653190.

  • Upload of filenames ending in .pom is not working (no content type found.) I'll try defaulting to application/xml for the pomFile Content-Type.
  • No success message displays after a successful upload [I don't think this was working before my changes...]
  • filename.replaceAll( packaging, "pom" ) is dangerous; if 'jar' or 'war' appears elsewhere in the path it's going to get replaced.
  • The groupId/artifactId/version/packaging fields are still required even if a pom file is supplied. (This differs from deploy:deploy-file which can read them from the pom.)
  • No validation that the uploaded POM file matches the supplied groupId/artifactId/etc.
  • Documentation still needs to be updated
  • Should checksums be created for the uploaded files? We currently only do it for the metadata file. (Archiva can be configured to "fix checksums".)
  • Automated tests?
Show
Wendy Smoak added a comment - Initial work done in r653190.
  • Upload of filenames ending in .pom is not working (no content type found.) I'll try defaulting to application/xml for the pomFile Content-Type.
  • No success message displays after a successful upload [I don't think this was working before my changes...]
  • filename.replaceAll( packaging, "pom" ) is dangerous; if 'jar' or 'war' appears elsewhere in the path it's going to get replaced.
  • The groupId/artifactId/version/packaging fields are still required even if a pom file is supplied. (This differs from deploy:deploy-file which can read them from the pom.)
  • No validation that the uploaded POM file matches the supplied groupId/artifactId/etc.
  • Documentation still needs to be updated
  • Should checksums be created for the uploaded files? We currently only do it for the metadata file. (Archiva can be configured to "fix checksums".)
  • Automated tests?
Hide
Permalink
Wendy Smoak added a comment -

> Upload of filenames ending in .pom is not working (no content type found.)

So far, it seems to only be a problem with Safari. Firefox works fine. Still needs to be tested with Internet Explorer. Looks like a "fix" would involve extending the Fileupload Interceptor (setting the Content-Type in the action is too late). Workaround: rename the .pom file to .xml before uploading.

Show
Wendy Smoak added a comment - > Upload of filenames ending in .pom is not working (no content type found.) So far, it seems to only be a problem with Safari. Firefox works fine. Still needs to be tested with Internet Explorer. Looks like a "fix" would involve extending the Fileupload Interceptor (setting the Content-Type in the action is too late). Workaround: rename the .pom file to .xml before uploading.
Hide
Permalink
Maria Odea Ching added a comment -
  • Should checksums be created for the uploaded files? We currently only do it for the metadata file. (Archiva can be configured to "fix checksums".)

In MRM-216, only the checksums of the metadata files are updated. I left the checksums of the artifact & the pom file to be generated by Archiva when the consumers are executed.

Show
Maria Odea Ching added a comment -
  • Should checksums be created for the uploaded files? We currently only do it for the metadata file. (Archiva can be configured to "fix checksums".)
In MRM-216, only the checksums of the metadata files are updated. I left the checksums of the artifact & the pom file to be generated by Archiva when the consumers are executed.
Hide
Permalink
Wendy Smoak added a comment -

Docs updated in r653665.

This is probably as done as it's going to get for 1.1, though it still needs work.

  • Do uploads done through the web interface show up in the audit log?
  • Do plugin uploads work correctly? (Needs latest and release elements in the metadata.)
Show
Wendy Smoak added a comment - Docs updated in r653665. This is probably as done as it's going to get for 1.1, though it still needs work.
  • Do uploads done through the web interface show up in the audit log?
  • Do plugin uploads work correctly? (Needs latest and release elements in the metadata.)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.