Clients timeout due to Archiva blocking when downloading large files

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.0, 1.0.1
  • Fix Version/s: Backlog
  • Component/s: WebDAV Interface
  • Labels:
    None

Description

Clients connecting to Archiva may time out when Archiva is proxying large files from an up stream remote repository.

Internally, Archiva uses Wagon and Plexus webdav which can only reference resources as JAVA File objects. Thus, Archiva must wait until Wagon has finished downloading from the remote repository before it can return the valid File object to the Plexus Webdav Servlet.

Issue Links

depends upon

New Feature - A new feature of the product, which has yet to be developed. WAGON-101 Allow use of streams for get, getIfNewer and put

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. MRM-781 Removal of Archiva-Webdav implementation in favor of Jackrabbit-webdav

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Task - A task that needs to be done. MRM-1347 Migrate repository proxy to the new repository API

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
supercedes

New Feature - A new feature of the product, which has yet to be developed. MRM-643 archiva should start to offer the file being proxied to the client while it concurrently downloads it

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jameswdumay added a comment -

Brett, could you please look at this patch and see if its going down the right track?

Show
jameswdumay added a comment - Brett, could you please look at this patch and see if its going down the right track?
Hide
Permalink
Brett Porter added a comment -

yep, looks ok - I realise there's some missing bits and I'd prefer a RuntimeException (say, UnsupportedOperationException) for the wagon's that don't support features instead of TransferFailedException, but otherwise I think it's ok.

Show
Brett Porter added a comment - yep, looks ok - I realise there's some missing bits and I'd prefer a RuntimeException (say, UnsupportedOperationException) for the wagon's that don't support features instead of TransferFailedException, but otherwise I think it's ok.
Hide
Permalink
jameswdumay added a comment -

I've changed this so it throws a StreamingNotSupportedException which is a little clearer.

Show
jameswdumay added a comment - I've changed this so it throws a StreamingNotSupportedException which is a little clearer.
Hide
Permalink
James William Dumay added a comment -

Move to 1.1.x

Show
James William Dumay added a comment - Move to 1.1.x
Hide
Permalink
Olivier Lamy added a comment -

fixed with wagon 2.0 integrated

Show
Olivier Lamy added a comment - fixed with wagon 2.0 integrated
Hide
Permalink
Brett Porter added a comment -

I think you meant something different - archiva will still block when it has to proxy a large artifact from a remote source.

It would be better to send the HEAD response, and stream some content as soon as possible. The only catch is deciding what to do with the connection if a remote checksum failure occurs after already starting to stream the content.

Show
Brett Porter added a comment - I think you meant something different - archiva will still block when it has to proxy a large artifact from a remote source. It would be better to send the HEAD response, and stream some content as soon as possible. The only catch is deciding what to do with the connection if a remote checksum failure occurs after already starting to stream the content.

People

  • Assignee:
    Brett Porter
    Reporter:
    James William Dumay
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: