Archiva

I just found out the project model information was not updated since it was not considered an unprocessed artifact. Therefore there was no consumer for updating database as it is for unprocessed artifacts, only for clean up. This problem happens only when you update a dependency version of a SNAPSHOT project that is already in the Archiva database.
I will see if I come up with a solution for this issue.

Attached are the patch files of all components that have been modified.

Please let me know if they are OK.

I applied the patches locally and it doesn't seem to work for me I tested it with the scenario specified above using maven-antrun-plugin as the test artifact. i've just edited the pom file itself (changed the dependency junit version from 3.8.1 to 3.8.2 ) instead of re-deploying after making the changes. I got this error during the database update:

jvm 1 | 2007-12-18 14:56:21,093 [pool-1-thread-1] ERROR org.apache.maven.archiva.consumers.DatabaseUnprocessedArtifactConsumer:update-db-project - Unable to process model /home/deng/TestFiles/sample-local-repo/org/apache/maven/plugins/maven-ant-plugin/2.0-beta-1/maven-ant-plugin-2.0-beta-1.pom due to : javax.jdo.JDOUserException : Field org.apache.maven.archiva.model.ArchivaProjectModel.origin is null, but is mandatory as its described in the jdo metadata
jvm 1 | javax.jdo.JDOUserException: Field org.apache.maven.archiva.model.ArchivaProjectModel.origin is null, but is mandatory as its described in the jdo metadata
jvm 1 | at org.jpox.store.rdbms.fieldmanager.ParameterSetter.storeStringField(ParameterSetter.java:120)
jvm 1 | at org.jpox.state.StateManagerImpl.providedStringField(StateManagerImpl.java:2757)
jvm 1 | at org.apache.maven.archiva.model.ArchivaProjectModel.jdoProvideField(ArchivaProjectModel.java)
jvm 1 | at org.apache.maven.archiva.model.ArchivaProjectModel.jdoProvideFields(ArchivaProjectModel.java)
jvm 1 | at org.jpox.state.StateManagerImpl.provideFields(StateManagerImpl.java:3115)
jvm 1 | at org.jpox.store.rdbms.request.InsertRequest.execute(InsertRequest.java:252)
jvm 1 | at org.jpox.store.rdbms.table.ClassTable.insert(ClassTable.java:2519)
jvm 1 | at org.jpox.store.StoreManager.insert(StoreManager.java:920)
jvm 1 | at org.jpox.state.StateManagerImpl.internalMakePersistent(StateManagerImpl.java:3667)
jvm 1 | at org.jpox.state.StateManagerImpl.makePersistent(StateManagerImpl.java:3646)
jvm 1 | at org.jpox.AbstractPersistenceManager.internalMakePersistent(AbstractPersistenceManager.java:1198)
jvm 1 | at org.jpox.AbstractPersistenceManager.makePersistent(AbstractPersistenceManager.java:1261)
jvm 1 | at org.apache.maven.archiva.database.jdo.JdoAccess.saveObject(JdoAccess.java:192)
jvm 1 | at org.apache.maven.archiva.database.jdo.JdoAccess.saveObject(JdoAccess.java:165)
jvm 1 | at org.apache.maven.archiva.database.jdo.JdoProjectModelDAO.saveProjectModel(JdoProjectModelDAO.java:86)
jvm 1 | at org.apache.maven.archiva.consumers.database.ProjectModelToDatabaseConsumer.processArchivaArtifact(ProjectModelToDatabaseConsumer.java:170)
jvm 1 | at org.apache.maven.archiva.database.updater.ProcessArchivaArtifactClosure.execute(ProcessArchivaArtifactClosure.java:52)
jvm 1 | at org.apache.commons.collections.CollectionUtils.forAllDo(CollectionUtils.java:388)
jvm 1 | at org.apache.maven.archiva.database.updater.JdoDatabaseUpdater.updateUnprocessed(JdoDatabaseUpdater.java:152)
jvm 1 | at org.apache.maven.archiva.database.updater.JdoDatabaseUpdater.updateAllUnprocessed(JdoDatabaseUpdater.java:86)
jvm 1 | at org.apache.maven.archiva.scheduled.executors.ArchivaDatabaseUpdateTaskExecutor.executeTask(ArchivaDatabaseUpdateTaskExecutor.java:78)
jvm 1 | at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176)
jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690)
jvm 1 | at java.lang.Thread.run(Thread.java:595)

Was this the error you've mentioned regarding the effective cache in your email in the dev list?
It would really be better if you could also provide tests for these changes Thanks Darios!

Yes, that is correct. I would get this error if effective cache was not updated properly upon project removal.

Anyway, to make sure I was not missing anything, I've updated my working copy (trunk), applied the patches locally and forced a modification to a POM file by replacing one of its dependency version (tested against new deployment and manual change to a POM sitting in the repository). Everything worked as expected.

I would suggest you to do it from scratch once again:

1) Update working copy to latest revision and apply the patches.
2) Install and run local Archiva.
3) Create an empty repository.
4) Add two projects (A and B) to it where B depends on A
5) Follow the steps from test scenario.

BTW do you have any recommendation about creating test cases for Archiva ?
Any tip would be appreciated.

Thank you.

Yes, that is correct. I would get this error if effective cache was not updated properly upon project removal.

Anyway, to make sure I was not missing anything, I've updated my working copy (trunk), applied the patches locally and forced a modification to a POM file by replacing one of its dependency version (tested against new deployment and manual change to a POM sitting in the repository). Everything worked as expected.

I would suggest you to do it from scratch once again:

1) Update working copy to latest revision and apply the patches.
2) Install and run local Archiva.
3) Create an empty repository.
4) Add two projects (A and B) to it where B depends on A
5) Follow the steps from test scenario.

BTW do you have any recommendation about creating test cases for Archiva ?
Any tip would be appreciated.

Thank you.

Hi Dario, I re-applied the patch again and did as was specified in the test scenario. The result was still the same for me though I still got the same error. Maybe there were some other changes in your local copy that didn't get included in the patches you've submitted? Anyway, I'll also look into why I'm getting the error.

For the tests, you could take a look at some of the test cases in Archiva as reference. As much as possible, it is recommended to use mock objects for the tests and cover as many different scenarios as you can. Another tip too (though not related to the tests), is you can also submit just one patch for all your changes. Instead of doing a diff per module, you can just diff on the top level directory

Thanks again!

Applied the following sections from the archiva-database-consumers.patch in ProjectModelToDatabaseConsumer and DatabaseCleanupRemoveProjectConsumer:

// Force removal of project model from effective cache
String projectKey = toProjectKey( projectModel );
synchronized ( effectiveProjectCache )
{
if ( effectiveProjectCache.hasKey( projectKey ) )

}
...
private String toProjectKey( ArchivaProjectModel project )

Other changes made:

• delete the project model if it already exists in the database (ProjectModelToDatabaseConsumer)
• added the effective-project-cache component in the DatabaseCleanupRemoveProjectModelTest

The above fixes are in -r637928. Thanks!