Archiva

regression : server-side relocation fails

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-4
  • Fix Version/s: 1.0
  • Component/s: WebDAV Interface
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

1.0-beta-4 introduces a regression in maven1 request handling :

simply try to get :
http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar

two causes :

1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().

2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.

point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

  1. MRM-595.patch
    15/Nov/07 2:57 AM
    17 kB
    nicolas de loof
  2. plexus-webdav-api.patch
    15/Nov/07 2:57 AM
    2 kB
    nicolas de loof

Activity

Hide
nicolas de loof added a comment -
  • simple change on plexus-webdav-api to support logicalResource beeing changed after the DavServerRequest has been created.
  • change on archiva-webapp ProxiedDavServer to fecth from proxied prior to computing the resource File
  • testcase to demonstrate the issue and the Fix.
Show
nicolas de loof added a comment -
  • simple change on plexus-webdav-api to support logicalResource beeing changed after the DavServerRequest has been created.
  • change on archiva-webapp ProxiedDavServer to fecth from proxied prior to computing the resource File
  • testcase to demonstrate the issue and the Fix.
Hide
nicolas de loof added a comment - - edited

my patch contains a stupid typo on archiva parent POM for <dependencyManagement> : plexus-webdav-api version is 1.0-beta-2-SNAPSHOT and not 1.0-beta-2-SNAPSHO*S*T

Show
nicolas de loof added a comment - - edited my patch contains a stupid typo on archiva parent POM for <dependencyManagement> : plexus-webdav-api version is 1.0-beta-2-SNAPSHOT and not 1.0-beta-2-SNAPSHO*S*T

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: