The Reports link gives an HTTP 500

The other type used here seems to be : ArchivaArtifact

This is being postponed to 1.0-alpha-2

I've attached a preliminary work of how archiva can use JasperReports as its reporting mechanism. It's functional but there are a lot of aesthetics work to be done.

Aside from the look, there are a lot of things to discuss:
1. Do we need to put in the links for the pages? Such as, when using Google, there are a number of links that corresponds to the resulting pages. Example: <1><2><3>...<Last Page>

2. Do we put in the functionality that a user can choose the resulting number of rows per page? Currently I've hard coded this to 10 rows per page as I don't have a lot of sample to work on. And it's hard to put this number in between pages. It would be better to have the user choose the number first before starting the report. We can't put an editable text field on the JasperReport page. Or I just can't find a sample of it on the web. ^_

3. The last page for now is blank. Will work on this maybe tomorrow. Depends on the responds I get from the list or here.

4. I've queried the DB straight from the action. I understand the DB management quite well but had a hard time understanding the ReportingManager. Would it be better to wrap the DB queries from ReportingManager?

5. This is related to item 4. As I don't understand the ReportingManager fully and I need to get a limited number of rows. I've added a range constraint that would do this. I'm not sure on this implementation. JPOX documentation says that it's only "implemented efficiently" on a couple of DBs. http://www.jpox.org/docs/1_2/jdo/query.html

6. Anyone who can point me to a good jrxml document would be helpful. I can't seem to have <staticText> working. So I use <textField> instead.

Feedback will be greatly appreciated.

Thanks!

Opps... I forgot to attach the model patch.

Good work on the reports Teody!

I've applied the patch in my local machine to try it out and here are my comments:
1. For the number links, I think it would be better to have it that way so that it's easier for the user to browse through the report.
2. I also agree on giving the user the functionality to choose the resulting number of rows per page.
3. It would be nice if there is a default message that tells the user that there are no errors to be reported when the user clicks 'Reports' in the navigation menu, instead of just a blank page.
4. Maybe the report should be renamed to something else other than 'All Problematic Artifacts' (hehe.. I felt like these artifacts were depressed)

I'm not sure about #4 and #5, I think you should ask Joakim about it.
For #6, you could try generating a jrxml file using iReport and see how the <staticText> works

Hi,

Updated patch(20070801) attached.
Comments and suggestions will be greatly appreciated.

Thanks!

it's normally best not to date the patches - that way the new ones just obsolete the old ones and it's easiest to figure out which ones to apply

and also one patch from the root directory is easier to apply

looks good!

comments from the usage side:

• what's the use case for searching by artifact ID? I can understand the group filter, but not sure about the others
• can the repository list easily be a dropdown?
• I'd put them all in one form, so each field is an additional constraint (and the default is just to show everything)
• I don't think the final report should be skinned - it doesn't really fit
• I'd drop the last 3 columns from the table
• how come a separate java app is started when this is generated? (tanuki WrapperSimpleApp) - or is this just me?

haven't eval'd the code...

Thanks for the patch Teody.. the reports definitely looks better now

I agree with Brett's comments, especially the constraints/fields being grouped together in one form. It'll be easier for the user to use.
Below are some additional comments:

• Can the version link in the reports be removed? I think it would always display the 'Unable to find...' error message whenever you click it since the project model is never added to the database once it is found to be invalid
• Could you provide some unit tests for these?
• And lastly, what about the reports not being accessible to only those users with admin roles? Should that be included here? Or is that a separate issue?

Btw, I didn't see the tanuki WrapperSimpleApp started when I executed the reports

Patches look good.

Great work Teody!

Patches applied in revision 562233.

Hi Guys,

I've attached the latest patch with changes in my email yesterday on the dev mailing list.
Patch is now formatted with Brett's comments taken into consideration. Thanks for the info Brett!

Changes:
-Taken out Artifact search

-Taken out Version link
-Repository list now a drop down

-Consolidated all the fields into 1 form

-Dropped the last 3 columns from the table

-Unit tests for all the constraints

Lacking:
-Unit tests for the actions and the model (can someone help me out as to how to test the action? how do we inject the dao from the test environment?)
-Form validation (especially the rowCount, which needs a positive number)
-Profile regarding licensing of JasperReports discussed in the dev mailing list

Comments are always welcome!

couple of tweaks I'd make:

• if you enter org.apache, look for org.apache*
• add "(All Repositories)" as the text on the default repository id.

applied, thanks!