Archiva

html js transversal review

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: ui-rewrite
  • Fix Version/s: 1.4-M3
  • Component/s: Web Interface
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

This task is to share potential html/js bad code. (Mainly taken from netbeans editor hinter )

#1 ending body misplaced in index.html and index_dev.html

#2 potential affectation in condition

#3 ;;

  1. Text File
    indexbody.patch
    02/Mar/12 5:02 PM
    2 kB
    Eric Barboni
  2. Text File
    javascriptmime.patch
    23/Mar/12 7:05 PM
    3 kB
    Eric Barboni

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

fixed r1296592
Thanks!

Show
Olivier Lamy added a comment - fixed r1296592 Thanks!
Hide
Permalink
Eric Barboni added a comment -

javascript type to application/javascript just for modernity.

Show
Eric Barboni added a comment - javascript type to application/javascript just for modernity.
Hide
Permalink
Olivier Lamy added a comment -

@Eric I'm not sure type="application/javascript" is supported by ie8 (maybe 9).
I cannot test as I don't windauze here

Show
Olivier Lamy added a comment - @Eric I'm not sure type="application/javascript" is supported by ie8 (maybe 9). I cannot test as I don't windauze here

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Eric Barboni
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: