Archiva
  1. Archiva
  2. MRM-1304

Query using Group ID field in audit log report uses '/' as a separator instead of '.'

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.1
    • Component/s: reporting, Web Interface
    • Labels:
      None
    • Number of attachments :
      4

      Description

      For groupIds with '.' (e.g. com.mycompany), you should use '/' instead (e.g. com/mycompany) as the artifact details are stored as artifact paths.

      1. MRM-1304.patch
        3 kB
        Adelita L. Padilla
      2. MRM-1304.patch
        3 kB
        Adelita L. Padilla
      3. Updated_MRM-1304.patch
        3 kB
        Adelita L. Padilla
      4. MRM-1304.patch
        3 kB
        Adelita L. Padilla

        Activity

        Hide
        Adelita L. Padilla added a comment -

        Fix and test attached.

        Show
        Adelita L. Padilla added a comment - Fix and test attached.
        Hide
        Adelita L. Padilla added a comment -

        Attached is the revised fix.

        Thanks!

        Show
        Adelita L. Padilla added a comment - Attached is the revised fix. Thanks!
        Hide
        Adelita L. Padilla added a comment -

        Attached updated patch. (Updated_MRM-1304.patch)

        • Fix and Test included

        Please disregard the 2 previous attachments.

        Thanks!

        Show
        Adelita L. Padilla added a comment - Attached updated patch. (Updated_ MRM-1304 .patch) Fix and Test included Please disregard the 2 previous attachments. Thanks!
        Hide
        Brett Porter added a comment -

        It's best to use the same name, since JIRA greys out the older ones

        Show
        Brett Porter added a comment - It's best to use the same name, since JIRA greys out the older ones
        Hide
        Brett Porter added a comment -

        the patch looks fine, and thanks for adding a test!

        I would only nitpick a couple of things:

        • please fix the formatting in the patch (http://archiva.apache.org/developers/how-we-do-things.html). You might like to get the IDE code settings from the Maven site and use that to reformat your changes
        • modifiedGroup can be created in the block - there's no reason for it to exist outside the if (nor be initialised separately).
        Show
        Brett Porter added a comment - the patch looks fine, and thanks for adding a test! I would only nitpick a couple of things: please fix the formatting in the patch ( http://archiva.apache.org/developers/how-we-do-things.html ). You might like to get the IDE code settings from the Maven site and use that to reformat your changes modifiedGroup can be created in the block - there's no reason for it to exist outside the if (nor be initialised separately).
        Hide
        Adelita L. Padilla added a comment -

        Attached revised patch for the fix and test.

        Fixed formatting and removed the extra line for modifiedGroupId.

        Thanks!

        Show
        Adelita L. Padilla added a comment - Attached revised patch for the fix and test. Fixed formatting and removed the extra line for modifiedGroupId. Thanks!
        Hide
        Brett Porter added a comment -

        the patch is missing the method name for the test case (Which is also disabled - have you checked it works on firefox?)

        Show
        Brett Porter added a comment - the patch is missing the method name for the test case (Which is also disabled - have you checked it works on firefox?)
        Hide
        Brett Porter added a comment -

        I've applied this, the fix looks fine.

        I had to modify the Selenium test a bit to work, however.

        Show
        Brett Porter added a comment - I've applied this, the fix looks fine. I had to modify the Selenium test a bit to work, however.

          People

          • Assignee:
            Brett Porter
            Reporter:
            Maria Odea Ching
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: