Maven 2.x Resources Plugin

Filtering fails for command line properties

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.3
  • Component/s: None
  • Labels:
    None
  • Environment:
    maven-2.0.4 and maven-2.0.5
    Mac OS X
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

When passing a property on the command line to maven using -D it does not properly override values passed to filters.

I have attached a sample project that defines a property in the pom.xml called 'filtered' This property is used as a filter in the filtered.properties file in src/main/filtered/filtered.properties. I have also included a test that gets passed the filtered property as a System property via the surefire plugin. It then loaded the filtered.properties file and tests to ensure the filters match.

The tests pass when run as

mvn test

BUT if I run as

mvn -Dfiltered=from-cmd-line teset

They fail.

I have also included the antrun plugin print its perspective on the value of the property.

Issue Links

depends upon

Improvement - An improvement or enhancement to an existing feature or task. MRESOURCES-56 use (and release) the maven-filtering component

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-85 command line cannot overwrite pom properties

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRESOURCES-101 command-line properties not regarded sometimes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Improvement - An improvement or enhancement to an existing feature or task. MRESOURCES-6 When filtering, properties defined in <project><properties> should be allowed as well.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jimmy kemp added a comment -

No patches supplied - but a workaround.
It seems maven requires a filter and testfilter property file to exist under the default directory 'src/test//filters/testfilter.properties' and then defined in your pom.

command line parameters then override all other types of parameters set elsewhere.

e.g.
<build>
<resources>
<resource>
<directory>src/main/resources</directory>
<includes>
<include>*/.*</include>
</includes>
<filtering>true</filtering>
</resource>
</resources>
<filters>
<filter>src/main/filters/filter.properties</filter>
<filter>
src/test/filters/testfilter.properties
</filter>
</filters>

</build>

Show
jimmy kemp added a comment - No patches supplied - but a workaround. It seems maven requires a filter and testfilter property file to exist under the default directory 'src/test//filters/testfilter.properties' and then defined in your pom. command line parameters then override all other types of parameters set elsewhere. e.g. <build> <resources> <resource> <directory>src/main/resources</directory> <includes> <include>* / .*</include> </includes> <filtering>true</filtering> </resource> </resources> <filters> <filter>src/main/filters/filter.properties</filter> <filter> src/test/filters/testfilter.properties </filter> </filters> </build>
Hide
Permalink
Paul Gier added a comment -

The problem seems to be that the resources plugin first adds all the system properties to it's properties object, then adds properties from project.getProperties(). So the project properties override the system properties.

The patch reverses this order, and changes one test case to reflect this change. The only problem I see is if you wanted to override some default system property (for example "user.home") in your pom, you wouldn't be able to do this anymore. I didn't find any easy way to get just the command line props from within the plugin, but if this was possible it would probably be a better solution.

Show
Paul Gier added a comment - The problem seems to be that the resources plugin first adds all the system properties to it's properties object, then adds properties from project.getProperties(). So the project properties override the system properties. The patch reverses this order, and changes one test case to reflect this change. The only problem I see is if you wanted to override some default system property (for example "user.home") in your pom, you wouldn't be able to do this anymore. I didn't find any easy way to get just the command line props from within the plugin, but if this was possible it would probably be a better solution.
Hide
Permalink
Paul Gier added a comment -

The project properties were added to the filter properties in MRESOURCES-6.

Show
Paul Gier added a comment - The project properties were added to the filter properties in MRESOURCES-6 .
Hide
Permalink
A added a comment - - edited

There was a propertyset in ANT where you can select only command-line options as a selector. I can't find Project and other classes' description in maven's Javadoc API so this is pure guess.

I'll try the patch these days, thanks!

Show
A added a comment - - edited There was a propertyset in ANT where you can select only command-line options as a selector. I can't find Project and other classes' description in maven's Javadoc API so this is pure guess. I'll try the patch these days, thanks!
Hide
Permalink
A added a comment - - edited

Sorry I'm new to mvn... How can I use the patched plug-in? I've built it but couldn't find a way to make maven pick it up.

Ah, it just needs to be in the local repo. How can I make sure it is used when put on a private repository?

Btw I don't think overwriting jvm default properties from POM is a big issue since that would be kind of hack and should be done on cmdline if needed.

Thanks for the patch and hope it will be included in next plug-in versions!

Show
A added a comment - - edited Sorry I'm new to mvn... How can I use the patched plug-in? I've built it but couldn't find a way to make maven pick it up. Ah, it just needs to be in the local repo. How can I make sure it is used when put on a private repository? Btw I don't think overwriting jvm default properties from POM is a big issue since that would be kind of hack and should be done on cmdline if needed. Thanks for the patch and hope it will be included in next plug-in versions!
Hide
Permalink
Benjamin Bentmann added a comment -

We should have Milos or somebody with similiar skills in embedded development review this issue. I doubt that directly using the system properties is the correct approach. IIRC, there were execution properties from MavenSession that should be used instead.

Show
Benjamin Bentmann added a comment - We should have Milos or somebody with similiar skills in embedded development review this issue. I doubt that directly using the system properties is the correct approach. IIRC, there were execution properties from MavenSession that should be used instead.
Hide
Permalink
Basil James Whitehouse III added a comment -

Could someone with privileges mark this as affecting version 2.2 of the resources plugin to make it a bit easier for others to find.

Show
Basil James Whitehouse III added a comment - Could someone with privileges mark this as affecting version 2.2 of the resources plugin to make it a bit easier for others to find.
Hide
Permalink
Olivier Lamy added a comment -

As the plugin now use the maven filtering component, this should be fixed.
Have a look at the order defined here http://maven.apache.org/shared/maven-filtering.
Can you try it a snapshot has deployed.
I leave this issue open until a it has been written for this.

Show
Olivier Lamy added a comment - As the plugin now use the maven filtering component, this should be fixed. Have a look at the order defined here http://maven.apache.org/shared/maven-filtering . Can you try it a snapshot has deployed. I leave this issue open until a it has been written for this.
Hide
Permalink
Olivier Lamy added a comment -

it added in rev 692758

Show
Olivier Lamy added a comment - it added in rev 692758
Hide
Permalink
Eric Miller added a comment -

Not sure where this issue is. I was using 2.5, but command line property overrides do not work in that version. It works in version 2.4.

Show
Eric Miller added a comment - Not sure where this issue is. I was using 2.5, but command line property overrides do not work in that version. It works in version 2.4.
Hide
Permalink
Brian Chapman added a comment -

Version 2.6 re-fixes the issue.

Show
Brian Chapman added a comment - Version 2.6 re-fixes the issue.

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Matt Brozowski
Vote (8)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: