Maven 2.x Release Plugin

release:perform in subdirectories fails if localCheckout=true

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.3
  • Component/s: Git, perform
  • Labels:
    None
  • Number of attachments :
    1

Description

This bug only concerns DSCMs like hg or GIT.

Currently the release:perform fails when the project which should be released is not in the outermost directory of the SCM repository and the localCheckout feature is enabled. In this case we just do a file:// checkout from the current directory. But if the project being released is not in the outermost directory, then the present working directory doesn't contain a GIT repo but some parent directory does.
This is related to MRELEASE-501.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-754 Git clone fails during perform when using localCheckout

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-727 release plugin uses wrong checkout directory

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

New Feature - A new feature of the product, which has yet to be developed. MRELEASE-501 create the possibility for performing a local checkout instead a clean checkout from the upstream repository for DSCMs

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
supercedes

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-702 Could not release project due to GIT clone error when working in sub-directory

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark Struberg added a comment -

fixed in r1245806.

we now move up to the parent directories if the local checkout fails - until we hit the root or the checkout succeeds.

Show
Mark Struberg added a comment - fixed in r1245806. we now move up to the parent directories if the local checkout fails - until we hit the root or the checkout succeeds.
Mark Struberg made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Assignee Mark Struberg [ struberg ]
Fix Version/s 2.2.3 [ 18334 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Florent PAILLARD added a comment - - edited

Hello Mark,

Thanks a lot for fixing this! That's really precious!

I encounter 2 little problems under Windows.

First one is when the scmUrl is built. In CheckoutProjectFromScm class at line 88.
Under Windows, providing a url of the form "scm:git:file://d:/users/blabla/etc/" is resolved by Git a "file://d/users/blabla/etc". Note that the /d:/ became /d/. Then git fails because it cannot checkout this not existing directory.
The workaround is to provide a url of the form: "scm:git:file:///d:/users/blabla/etc/" (with a triple slash "///" between file: and d
I don't know if it also works under other systems.

Second problem is when you get to the parent folder to try to checkout. Also in CheckoutProjectFromScm class at line 107. Instead of
int lastSlashPos = scmPath.lastIndexOf( "/" )
it should be
int lastSlashPos = scmPath.lastIndexOf( System.getProperty("file.separator") )

That would be really great if you could fix that before the next MRELEASE version! Do I need to create a new issue for that?

Kind Regards,

Show
Florent PAILLARD added a comment - - edited Hello Mark, Thanks a lot for fixing this! That's really precious! I encounter 2 little problems under Windows. First one is when the scmUrl is built. In CheckoutProjectFromScm class at line 88. Under Windows, providing a url of the form "scm:git: file://d:/users/blabla/etc/ " is resolved by Git a "file://d/users/blabla/etc". Note that the /d:/ became /d/. Then git fails because it cannot checkout this not existing directory. The workaround is to provide a url of the form: "scm:git: file:///d:/users/blabla/etc/ " (with a triple slash "///" between file: and d I don't know if it also works under other systems. Second problem is when you get to the parent folder to try to checkout. Also in CheckoutProjectFromScm class at line 107. Instead of int lastSlashPos = scmPath.lastIndexOf( "/" ) it should be int lastSlashPos = scmPath.lastIndexOf( System.getProperty("file.separator") ) That would be really great if you could fix that before the next MRELEASE version! Do I need to create a new issue for that? Kind Regards,
Hide
Permalink
Mark Struberg added a comment -

Txs Florent! I'll fix those little bugs asap.

Show
Mark Struberg added a comment - Txs Florent! I'll fix those little bugs asap.
Mark Struberg made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Hide
Permalink
Jukka Zitting added a comment -

Any thoughts on when version 2.3 will be out? I'd really love to see this fix in an official release.

Show
Jukka Zitting added a comment - Any thoughts on when version 2.3 will be out? I'd really love to see this fix in an official release.
Hide
Permalink
Mark Struberg added a comment -

Hi Florent!

Can you please test the following patch?

Please note that this also requires the patch from MRELEASE-727 as well! Otherwise the correct path will not be found.

Show
Mark Struberg added a comment - Hi Florent! Can you please test the following patch? Please note that this also requires the patch from MRELEASE-727 as well! Otherwise the correct path will not be found.
Mark Struberg made changes -
Attachment MRELEASE-740.patch [ 59745 ]
Hide
Permalink
Florent PAILLARD added a comment -

Hi Mark

It works here under Windows !

Thanks

Show
Florent PAILLARD added a comment - Hi Mark It works here under Windows ! Thanks
Hide
Permalink
Mark Struberg added a comment -

committed in r1332386.

txs for the patch Florent!

Show
Mark Struberg added a comment - committed in r1332386. txs for the patch Florent!
Mark Struberg made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Robert Scholte made changes -
Component/s Git [ 14642 ]
Component/s perform [ 13616 ]
Robert Scholte made changes -
Link This issue is duplicated by MRELEASE-754 [ MRELEASE-754 ]
Mark Struberg made changes -
Link This issue is related to MRELEASE-727 [ MRELEASE-727 ]
Mark Struberg made changes -
Link This issue is related to MRELEASE-501 [ MRELEASE-501 ]
jurevert made changes -
Link This issue supercedes MRELEASE-702 [ MRELEASE-702 ]

People

  • Assignee:
    Mark Struberg
    Reporter:
    Mark Struberg
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: