Maven 2.x Release Plugin

release plugin uses wrong checkout directory

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.2, 2.2.2
  • Fix Version/s: 2.3
  • Component/s: perform
  • Labels:
    None
  • Environment:
    mvn 3.0.3
  • Number of attachments :
    4

Description

When performing a release build on a multi module project, the plugin uses a wrong checkout directory and therefore is unable to perform the release.
I tested this with both version 2.2 and 2.2.2

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.2.2:perform (default-cli) on project test_multi_parent: Error executing Maven. Working directory "/Users/domi/work/ws/sts_0/test_multi_parent/target/checkout/test_multi_parent/test_multi_parent" does not exist! -> [Help 1]

We use flat project structure (where parent and modul project are in the same directory)
The SVN Repo looks like this:

.../svnrepos/KUQ/trunk/test_multi_parent
.../svnrepos/KUQ/trunk/test_multi_module1

I'll attache a minimal test project to reproduce it and a file containing the whole log output for release:prepare and release:perform

To reproduce the problem:

  • adjust the SVN paths in the pom.xml
  • checkin to SVN
  • release:prepare
  • release:perform -Dgoals=install

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-725 Releasing a specific module-based project fails (Regression from 2.1)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-740 release:perform in subdirectories fails if localCheckout=true

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dominik Bartholdi added a comment -

This patch fixes the issue for flat project layouts.
All tests still run successfully.

All I did was to remove a line in the current RunPerformGoalsPhase code. It was assumed, that if the parent pom was in a subdirectory, then the SCM checkout directory would be in the parent directory if that pom, but for flat projects, that's not right...

Show
Dominik Bartholdi added a comment - This patch fixes the issue for flat project layouts. All tests still run successfully. All I did was to remove a line in the current RunPerformGoalsPhase code. It was assumed, that if the parent pom was in a subdirectory, then the SCM checkout directory would be in the parent directory if that pom, but for flat projects, that's not right...
Hide
Permalink
Olivier Lamy added a comment -

fixed r1245192.
Thanks!

Show
Olivier Lamy added a comment - fixed r1245192. Thanks!
Hide
Permalink
L. Compère added a comment -

Hi all!

I'm using maven 2.2.1 with maven-release-plugin in version 2.2.2 and am getting the problem initially mentioned "When performing a release build on a multi module project, the plugin uses a wrong checkout directory and therefore is unable to perform the release".

Is there a maven-release-plugin version I can use which fixes the problem?

I can't seem to find version 2.2.3.

thanks!

Show
L. Compère added a comment - Hi all! I'm using maven 2.2.1 with maven-release-plugin in version 2.2.2 and am getting the problem initially mentioned "When performing a release build on a multi module project, the plugin uses a wrong checkout directory and therefore is unable to perform the release". Is there a maven-release-plugin version I can use which fixes the problem? I can't seem to find version 2.2.3. thanks!
Hide
Permalink
Robert Scholte added a comment -

Latest release was 2.2.2, 2.3 hasn't been released yet. You could try the 2.3-SNAPSHOT

Show
Robert Scholte added a comment - Latest release was 2.2.2, 2.3 hasn't been released yet. You could try the 2.3-SNAPSHOT
Hide
Permalink
Marc added a comment - - edited

Is there a release date yet?

I configured our nexus to use apache-snapshots but I cannot find 2.3-SNAPSHOT. Is this plugin hosted somewhere else?
Thanks

Show
Marc added a comment - - edited Is there a release date yet? I configured our nexus to use apache-snapshots but I cannot find 2.3-SNAPSHOT. Is this plugin hosted somewhere else? Thanks
Hide
Permalink
Robert Scholte added a comment -

Snapshot is available at https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-release-plugin/
There are some critical issues related to SCM, so I'd like to wait to scm-1.7

Show
Robert Scholte added a comment - Snapshot is available at https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-release-plugin/ There are some critical issues related to SCM, so I'd like to wait to scm-1.7
Hide
Permalink
Mark Struberg added a comment -

unfortunately this breaks SCMs which don't support sparse checkout, like hg and GIT.
We need to find a solution which works for both.

Show
Mark Struberg added a comment - unfortunately this breaks SCMs which don't support sparse checkout, like hg and GIT. We need to find a solution which works for both.
Hide
Permalink
Mark Struberg added a comment -

Hi folks!

Could you please try the attached patch?
This version works with GIT and hg again and should also do for SVN. txs!

Show
Mark Struberg added a comment - Hi folks! Could you please try the attached patch? This version works with GIT and hg again and should also do for SVN. txs!
Hide
Permalink
Mark Struberg added a comment -

fix committed in r1332385.

I'll now only do the pom scan if the SCM itself doesn't offer a relativePath.

Show
Mark Struberg added a comment - fix committed in r1332385. I'll now only do the pom scan if the SCM itself doesn't offer a relativePath.
Hide
Permalink
Mark Struberg added a comment -

should now finally be fixed. Please reopen if there is still a scenario left which we didn't think about carefully enough.

Show
Mark Struberg added a comment - should now finally be fixed. Please reopen if there is still a scenario left which we didn't think about carefully enough.
Hide
Permalink
Sylvain LAURENT added a comment -

It still does not work with CVS : only the current project is checked out directly in "target/checkout" (so, the tagged pom.xml is created in target/checkout). And then mvn complains that the directory target/checkout/parentproject does not exist.

I cannot reopen this issue, it seems I don't have the rights in JIRA... Should I create a new issue ?

Show
Sylvain LAURENT added a comment - It still does not work with CVS : only the current project is checked out directly in "target/checkout" (so, the tagged pom.xml is created in target/checkout). And then mvn complains that the directory target/checkout/parentproject does not exist. I cannot reopen this issue, it seems I don't have the rights in JIRA... Should I create a new issue ?
Hide
Permalink
Mark Struberg added a comment -

yes, please create a new one. Do you folks really still use CVS? CVS is dead since 2006 ^^

Show
Mark Struberg added a comment - yes, please create a new one. Do you folks really still use CVS? CVS is dead since 2006 ^^

People

  • Assignee:
    Olivier Lamy
    Reporter:
    Dominik Bartholdi
Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: