maven-release-plugin doesn't pass username to maven-scm-provider-cvs

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

The class CvsScmProvider refuses a CVS url without username. See, for example, line 253ff:

int index = userhost.indexOf( "@" );

if ( index == -1 )

{ result.messages.add( "The userhost part must be on the form: <username>@<hostname>." ); return result; }

On the other hand, the maven-release-plugin doesn't pass the full URL to the provider. In AbstractReleaseMojo, an instance of ScmHelper is used, see line 120:

repository = getScmManager().makeScmRepository( scmHelper.getUrl() );

But the ScmHelper's URL is a reformatted URL, with user, password, and so on removed. The effect is that any attempt to run

mvn release:prepare

with an URL like scm:cvs:pserver:joe@host:/cvs:module is refused with an error message "The scm url is invalid."

I can't tell which side is wrong and am thus unable to provide a patch.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. SCM-123 scm plugin ignores -Dusername for CSV provider

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jochen Wiedmann added a comment -

Would anyone please be so kind to comment at least, whether my observations are correct and, if so, which side (maven-release-plugin or CVS provider) has to be fixed? If so, I could continue and provide a patch.

Show
Jochen Wiedmann added a comment - Would anyone please be so kind to comment at least, whether my observations are correct and, if so, which side (maven-release-plugin or CVS provider) has to be fixed? If so, I could continue and provide a patch.
Hide
Permalink
Pascal Grange added a comment -

I can't answer but I just want you to know that you are not alone

We are considering, in my company, switching to maven 2 but this bug is a blocker for us !

Show
Pascal Grange added a comment - I can't answer but I just want you to know that you are not alone We are considering, in my company, switching to maven 2 but this bug is a blocker for us !
Hide
Permalink
Brett Porter added a comment -

this should be a relatively simply fix in Maven SCM.

Show
Brett Porter added a comment - this should be a relatively simply fix in Maven SCM.
Hide
Permalink
Pascal Grange added a comment -

If it is a simple fix, when do you think a new release fixing this bug will be available ? I have to answer my boss.

Merry Christmas.

Show
Pascal Grange added a comment - If it is a simple fix, when do you think a new release fixing this bug will be available ? I have to answer my boss. Merry Christmas.
Hide
Permalink
Dan Tran added a comment -

mvn scm:validate -DconnectionUrl=scm:cvs:pserver:joe@host:/cvs:module -X

shows the url is valid. So the problem is in release plugin?

Show
Dan Tran added a comment - mvn scm:validate -DconnectionUrl=scm:cvs:pserver:joe@host:/cvs:module -X shows the url is valid. So the problem is in release plugin?
Hide
Permalink
Pascal Grange added a comment -

This is bug is a blocker for anyone using cvs as we are in my company.

One month after its submission by Jochen Wiedmann, how far are we from a fix ? Is it fixed by the way ?

Show
Pascal Grange added a comment - This is bug is a blocker for anyone using cvs as we are in my company. One month after its submission by Jochen Wiedmann, how far are we from a fix ? Is it fixed by the way ?
Hide
Permalink
Dennis Lundberg added a comment -

See SCM-123 for additional information regarding the necessity for a username and some documentation updates.

Show
Dennis Lundberg added a comment - See SCM-123 for additional information regarding the necessity for a username and some documentation updates.
Hide
Permalink
Dan Tran added a comment -

A reason thread at maven list show that

scm:cvs:pserver:joe:@host:/cvs:module ( note there is a : after joe )

works

would it be your temporary solution? or you want the the scm url without username ?

Show
Dan Tran added a comment - A reason thread at maven list show that scm:cvs:pserver:joe:@host:/cvs:module ( note there is a : after joe ) works would it be your temporary solution? or you want the the scm url without username ?
Hide
Permalink
Dan Tran added a comment -

should we move this to MRELEASE?

Show
Dan Tran added a comment - should we move this to MRELEASE?
Hide
Permalink
Adrian added a comment -

I imagine this is quite an easy fix, and is important to lots of people using CVS in a commercial environment.

Show
Adrian added a comment - I imagine this is quite an easy fix, and is important to lots of people using CVS in a commercial environment.
Hide
Permalink
Emmanuel Venisse added a comment -

Fixed in Maven-SCM

Show
Emmanuel Venisse added a comment - Fixed in Maven-SCM

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    Jochen Wiedmann
Vote (4)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: