Maven 2.x Release Plugin

CommonBasedir Calculation fails on windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.1
  • Component/s: prepare
  • Labels:
    None
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The method getCommonBasedir in class org.apache.maven.shared.release.util.ReleaseUtil runs into the Exception:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1

... while comparing pathes with small and capital lettes for Windows drives.

e.g.: C:\WoRkInG\root\project1 has no common base dir with c:\working\root\project2
but it should have c:\working\root as common base directory.

A patch and a test for that bug is attached.
I do have the problem with version 2.0 but I fixed it in trunk for now

Regards Matthias

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-523 ReleaseUtil throws "java.lang.StringIndexOutOfBoundsException: String index out of range: -1"

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. SCM-547 Release on Windows, of a multi-module project, using msysgit, throws a StringIndexOutOfBoundsException

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ricky Clarkson added a comment -

I found that the problem was triggered by msysgit (mingw) setting the current working directory to c:\foo rather than C:\foo, and that launching mvn from cmd instead of msysgit made the problem disappear. That said, if your patch solves it, great stuff.

Show
Ricky Clarkson added a comment - I found that the problem was triggered by msysgit (mingw) setting the current working directory to c:\foo rather than C:\foo, and that launching mvn from cmd instead of msysgit made the problem disappear. That said, if your patch solves it, great stuff.
Hide
Permalink
Lars Corneliussen added a comment -

Go the same problem. Hudson home dir was with capital drive letter... Still it is a bug, IMHO. Maybe CanonicalPath should be used all over... but then alot tests have to be refactored as well.

Show
Lars Corneliussen added a comment - Go the same problem. Hudson home dir was with capital drive letter... Still it is a bug, IMHO. Maybe CanonicalPath should be used all over... but then alot tests have to be refactored as well.
Hide
Permalink
Lars Corneliussen added a comment -

the patch breaks some tests

Show
Lars Corneliussen added a comment - the patch breaks some tests
Hide
Permalink
Francis De Brabandere added a comment - - edited

Might be a good idea to catch this -1 string index and throwing a proper exception indicating what goes wrong by showing both paths

we have this problem with subversion-based projects being released in hudson

[INFO] Working directory: c:\hudson\workspace\...\trunk

Show
Francis De Brabandere added a comment - - edited Might be a good idea to catch this -1 string index and throwing a proper exception indicating what goes wrong by showing both paths we have this problem with subversion-based projects being released in hudson [INFO] Working directory: c:\hudson\workspace\...\trunk
Hide
Permalink
Francis De Brabandere added a comment -

A workaround is to revert to the 2.0-beta-9 maven-release-plugin.

Show
Francis De Brabandere added a comment - A workaround is to revert to the 2.0-beta-9 maven-release-plugin.
Hide
Permalink
Brett Porter added a comment - - edited

is this the same as MRELEASE-546?

Show
Brett Porter added a comment - - edited is this the same as MRELEASE-546 ?
Hide
Permalink
Jan Sievers added a comment -

no this is different I think.
It's about non-case sensitive file name compare on windows platforms, i.e.

c:\TMP\foo.txt and
c:\tmp\Foo.txt

denote the same file on windows but the case sensitive String comparison fails to find the common basedir.

Show
Jan Sievers added a comment - no this is different I think. It's about non-case sensitive file name compare on windows platforms, i.e. c:\TMP\foo.txt and c:\tmp\Foo.txt denote the same file on windows but the case sensitive String comparison fails to find the common basedir.
Hide
Permalink
Francis De Brabandere added a comment -

here is a stacktrace:

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1937)
at org.apache.maven.shared.release.util.ReleaseUtil.getCommonBasedir(ReleaseUtil.java:206)
at org.apache.maven.shared.release.util.ReleaseUtil.getCommonBasedir(ReleaseUtil.java:177)
at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transformDocument(AbstractRewritePomsPhase.java:303)
at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transformProject(AbstractRewritePomsPhase.java:208)
at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transform(AbstractRewritePomsPhase.java:114)
at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.execute(AbstractRewritePomsPhase.java:97)
at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:203)
at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:140)
at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:103)
at org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:211)
at org.apache.maven.plugins.release.PrepareReleaseMojo.execute(PrepareReleaseMojo.java:181)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:284)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

Show
Francis De Brabandere added a comment - here is a stacktrace: java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1937) at org.apache.maven.shared.release.util.ReleaseUtil.getCommonBasedir(ReleaseUtil.java:206) at org.apache.maven.shared.release.util.ReleaseUtil.getCommonBasedir(ReleaseUtil.java:177) at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transformDocument(AbstractRewritePomsPhase.java:303) at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transformProject(AbstractRewritePomsPhase.java:208) at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transform(AbstractRewritePomsPhase.java:114) at org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.execute(AbstractRewritePomsPhase.java:97) at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:203) at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:140) at org.apache.maven.shared.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:103) at org.apache.maven.plugins.release.PrepareReleaseMojo.prepareRelease(PrepareReleaseMojo.java:211) at org.apache.maven.plugins.release.PrepareReleaseMojo.execute(PrepareReleaseMojo.java:181) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:569) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:539) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:284) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138) at org.apache.maven.cli.MavenCli.main(MavenCli.java:362) at org.apache.maven.cli.compat.CompatibleMain.main(CompatibleMain.java:60) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Hide
Permalink
Brett Porter added a comment -

patch to review

Show
Brett Porter added a comment - patch to review
Hide
Permalink
Brett Porter added a comment -

I think I'm seeing the same test failures on windows after applying the patch that Lars mentioned. Revising.

Show
Brett Porter added a comment - I think I'm seeing the same test failures on windows after applying the patch that Lars mentioned. Revising.
Hide
Permalink
Brett Porter added a comment -

Corrected getBaseWorkingDirectoryParentCount as well

Show
Brett Porter added a comment - Corrected getBaseWorkingDirectoryParentCount as well
Hide
Permalink
Anders Hammar added a comment -

This fix causes regression for clearcase on Windows. See MRELEASE-622.

Show
Anders Hammar added a comment - This fix causes regression for clearcase on Windows. See MRELEASE-622 .
Hide
Permalink
Jose Rodolfo Freitas added a comment -

Hey Guys,
I'm on 2.3.2 version of the release plugin and I have this exact error. I suspect that the exception is thrown by the same cause.
Is this a zombie bug?

Show
Jose Rodolfo Freitas added a comment - Hey Guys, I'm on 2.3.2 version of the release plugin and I have this exact error. I suspect that the exception is thrown by the same cause. Is this a zombie bug?
Hide
Permalink
Brett Porter added a comment -

Jose, the release notes for previous versions get locked down - it'd be best to file a new bug referring to this, with any additional information you can give to help replicate it with 2.3.2

Show
Brett Porter added a comment - Jose, the release notes for previous versions get locked down - it'd be best to file a new bug referring to this, with any additional information you can give to help replicate it with 2.3.2

People

  • Assignee:
    Brett Porter
    Reporter:
    Matthias Vach
Vote (6)
Watch (10)

Dates

  • Created:
    Updated:
    Resolved: