release plugin removes xml comments and attributes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0-beta-4
  • Component/s: None
  • Labels:
    None

Description

I noticed that maven-release-plugin has removed some elements in pom.xml files, during beta1 transition :

  • xml encoding;
  • Apache license;
  • xsd reference (Regression bug MNG-596)

Try a svn diff between 289378 and 289532 revisions for
components\maven-plugins\maven-site-plugin\pom.xml

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-15 Release plugin loses namespace information from pom.xml

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-88 Rewritten pom's loose comments and XSD definition

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Geoffrey De Smet added a comment -

Although most of the issues are now fixed, which is a huge improvement and enables the use of release:prepare, there are still 2 problems to reopen it.

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

turns into

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

So:

  • the ?xml version ... is removed (which gives problems for some xml editors)
  • the newline inside the xsd is removed (which makes the pom.xml a little bit unreadable.
Show
Geoffrey De Smet added a comment - Although most of the issues are now fixed, which is a huge improvement and enables the use of release:prepare, there are still 2 problems to reopen it. <?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> turns into <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> So:
  • the ?xml version ... is removed (which gives problems for some xml editors)
  • the newline inside the xsd is removed (which makes the pom.xml a little bit unreadable.
Hide
Permalink
Brett Porter added a comment -

the first is probably possible, but the second isn't with any of the apis I've looked at. Nothing tracks whitespace inside tags in the DOM.

It would probably require some comparison logic at the start to identify it and reapply it later, but its not trivial. We already do something similar to maintain comments outside the root tag which are also not preserved.

Show
Brett Porter added a comment - the first is probably possible, but the second isn't with any of the apis I've looked at. Nothing tracks whitespace inside tags in the DOM. It would probably require some comparison logic at the start to identify it and reapply it later, but its not trivial. We already do something similar to maintain comments outside the root tag which are also not preserved.

People

  • Assignee:
    Brett Porter
    Reporter:
    Vincent Siveton
Vote (5)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: