ForkedMavenExecutor assumes mvn is on command-line path

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: 2.0-beta-7
  • Fix Version/s: None
  • Component/s: perform, prepare, stage
  • Labels:
    None
  • Patch Submitted:
    Yes

Description

The ForkedMavenExecutor assumes the mvn executable is on the command-line path. This will cause the release goals to fail if mvn is run from an explicit path and the PATH environment variable has not be set to contain a mvn executable. More dangerously though is the case where the release goal is started with an explicit mvn executable of one version (for instance 2.0.8) but a different version of the mvn executable is available on the PATH. The forked processes will run a different version of Maven2 that the parent process.

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-428 ForkedMavenExecutor must use ${maven.home}/bin/mvn and not only mvn

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Jackson added a comment -

Attached patch with test case. The patch uses the maven.home system property to find the mvn executable. I now understand that the original process can't spawn children with a different maven version since the mvn script checks that the M2_HOME environment variable is set and matches the version running.

Show
Brian Jackson added a comment - Attached patch with test case. The patch uses the maven.home system property to find the mvn executable. I now understand that the original process can't spawn children with a different maven version since the mvn script checks that the M2_HOME environment variable is set and matches the version running.
Hide
Permalink
Martin Jaeger added a comment -

After all it should be possible to define the executable on the commandline / with a plugin property. The execution of "mvn" as a fixed string is not appropriate for our system. Since we wrote a wrapper script to select the correct maven version for a defined project.

Show
Martin Jaeger added a comment - After all it should be possible to define the executable on the commandline / with a plugin property. The execution of "mvn" as a fixed string is not appropriate for our system. Since we wrote a wrapper script to select the correct maven version for a defined project.
Hide
Permalink
Sam De Block added a comment -

This also conflicts when using M2Eclipse, because then you dont even have a separate maven install.
Basically this plugin doesnt work when maven is launched through the maven embedder.

Show
Sam De Block added a comment - This also conflicts when using M2Eclipse, because then you dont even have a separate maven install. Basically this plugin doesnt work when maven is launched through the maven embedder.
Hide
Permalink
Frederic Tardif added a comment -

issue on m2e side:

https://issues.sonatype.org/browse/MNGECLIPSE-1660

Show
Frederic Tardif added a comment - issue on m2e side: https://issues.sonatype.org/browse/MNGECLIPSE-1660
Hide
Permalink
Frederic Tardif added a comment -

is there a way that the release plugin could run without forking a maven to support it's integration when it is launched through the maven embedder?

Show
Frederic Tardif added a comment - is there a way that the release plugin could run without forking a maven to support it's integration when it is launched through the maven embedder?
Hide
Permalink
Olivier Lamy added a comment -

We have to wait a released version of the embedder.

Show
Olivier Lamy added a comment - We have to wait a released version of the embedder.
Hide
Permalink
Frederic Tardif added a comment -

any update about this issue? It is quite annoying since we can't use the maven-release-plugin with the embed m2e's maven.

Show
Frederic Tardif added a comment - any update about this issue? It is quite annoying since we can't use the maven-release-plugin with the embed m2e's maven.
Hide
Permalink
Robert Scholte added a comment -

Duplicate of MRELEASE-428, which was already fixed in version 2.0-beta-8

Show
Robert Scholte added a comment - Duplicate of MRELEASE-428, which was already fixed in version 2.0-beta-8

People

  • Assignee:
    Unassigned
    Reporter:
    Brian Jackson
Vote (7)
Watch (10)

Dates

  • Created:
    Updated:
    Resolved: