during release:prepare, if one of the goals specified in preparationGoals fails, the release:prepare should abort/fail, but it continues along as if nothing bad happened

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-6
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

In my case, I specified "clean install" as the value of preparationGoals. One of my unit tests failed, which caused the "mvn clean install" to fail, but release:prepare continued on and tagged the release as if nothing had gone wrong during the prep goals...

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-3084 mvn.bat in maven 2.0.7 does not return the correct error code.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emmanuel Venisse added a comment -

If you use maven 2.0.7 under windows, you must patch mvn.bat because it doesn't set the error code

Show
Emmanuel Venisse added a comment - If you use maven 2.0.7 under windows, you must patch mvn.bat because it doesn't set the error code
Hide
Permalink
Emmanuel Venisse added a comment -

sorry, closed by error

Show
Emmanuel Venisse added a comment - sorry, closed by error
Hide
Permalink
Ian Springer added a comment -

I am using Maven 2.0.7 on Windows XP, but my mvn.bat does appear to contain the logic to exit with the same exit code as the Maven java process.

Can you point me to the mvn.bat patch you mentioned?

Thanks,
Ian

Show
Ian Springer added a comment - I am using Maven 2.0.7 on Windows XP, but my mvn.bat does appear to contain the logic to exit with the same exit code as the Maven java process. Can you point me to the mvn.bat patch you mentioned? Thanks, Ian
Hide
Permalink
Olivier Lamy added a comment -

I think if you have upgraded your maven, you shouldn't have the issue.
If not please reopen the issue.

Show
Olivier Lamy added a comment - I think if you have upgraded your maven, you shouldn't have the issue. If not please reopen the issue.

People

  • Assignee:
    Unassigned
    Reporter:
    Ian Springer
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: