If there is more than one artifact with the same artifactId in dependencyManagement only the first one is updated

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.0-beta-4
  • Fix Version/s: None
  • Component/s: prepare
  • Labels:
    None
  • Environment:
    Maven 2.0.4 under windows
  • Testcase included:
    yes
  • Patch Submitted:
    Yes

Description

I have a multi module project. When I do release:prepare, the release plugin update the version tag of all my submodules in the dependencyManagement section.
For the same module I have declared two artifacts like this :

<dependency>
  <groupId>com.bla</groupId>
  <artifactId>blabla</artifactId>
  <version>1.0-SNAPSHOT</version>
  <type>test-jar</type>
  <scope>test</scope>
</dependency>
<dependency>
  <groupId>com.bla</groupId>
  <artifactId>blabla</artifactId>
  <version>1.0-SNAPSHOT</version>
</dependency>

In this case, the release plugin only update the first dependency.

This is due to element search in the "updateDomVersion" method of the AbstractRewritePomsPhase class. I've attached a patch to solve the problem. I don't know if this is the right way to do. I change all the artifacts in the same pass. I don't take car of different type/classifier

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-634 Versions of snapshot dependencies to the same artifact with different classifiers are not updated correctly during release:prepare

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MRELEASE-659 snapshot dependency check on preparation of release: check artifacts WITH versions

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MNG-2871 Subartifact (ejb-client, test-jar etc.) are not reselved as active project artifacts in build phases prior to package

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Wewerka added a comment -

With 2.0-beta-5 and maven 2.0.6 a related issue (two dependencies to a project, one to the normal artifact, one to the test-jar) results in an error:

[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.

Missing:
----------
1) com.o2.release-test:release-test-module-one:test-jar:tests:5.0.2

I've attached a testcase to reproduce this bug.

Show
Chris Wewerka added a comment - With 2.0-beta-5 and maven 2.0.6 a related issue (two dependencies to a project, one to the normal artifact, one to the test-jar) results in an error: [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Failed to resolve artifact. Missing: ---------- 1) com.o2.release-test:release-test-module-one:test-jar:tests:5.0.2 I've attached a testcase to reproduce this bug.
Hide
Permalink
Chris Wewerka added a comment -

Testcase for the above comment

Show
Chris Wewerka added a comment - Testcase for the above comment
Hide
Permalink
Vincent Dupain added a comment -

There a workflow to this bug: generate one jar that merge main jar and test jar:
<build>
<resources>
<resource>
<directory>src/main/java</directory>
<targetPath>../../src/merge/java</targetPath>
</resource>
<resource>
<directory>src/test/java</directory>
<targetPath>../../src/merge/java</targetPath>
</resource>
</resources>
<sourceDirectory>src/merge/java</sourceDirectory>

<plugins>
<plugin>
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<filesets>
<fileset>
<directory>src/merge/java</directory>
</fileset>
</filesets>
</configuration>
</plugin>
...
<build>

and in the pom that depends on the 2 jars, you only have to depend on the main jar
<dependencies>
<!-- Kamayo Dependencies -->
<!--
<dependency>
<groupId>com.kamayo</groupId>
<artifactId>core</artifactId>
<version>${version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
-->
<dependency>
<groupId>com.kamayo</groupId>
<artifactId>core</artifactId>
<version>${version}</version>
<type>jar</type>
</dependency>
...
</dependencies>

Show
Vincent Dupain added a comment - There a workflow to this bug: generate one jar that merge main jar and test jar: <build> <resources> <resource> <directory>src/main/java</directory> <targetPath>../../src/merge/java</targetPath> </resource> <resource> <directory>src/test/java</directory> <targetPath>../../src/merge/java</targetPath> </resource> </resources> <sourceDirectory>src/merge/java</sourceDirectory> <plugins> <plugin> <artifactId>maven-clean-plugin</artifactId> <configuration> <filesets> <fileset> <directory>src/merge/java</directory> </fileset> </filesets> </configuration> </plugin> ... <build> and in the pom that depends on the 2 jars, you only have to depend on the main jar <dependencies> <!-- Kamayo Dependencies --> <!-- <dependency> <groupId>com.kamayo</groupId> <artifactId>core</artifactId> <version>${version}</version> <type>test-jar</type> <scope>test</scope> </dependency> --> <dependency> <groupId>com.kamayo</groupId> <artifactId>core</artifactId> <version>${version}</version> <type>jar</type> </dependency> ... </dependencies>
Hide
Permalink
Reimo Daum added a comment -

I attached possible solution for this bug - it does not break tests but i'm not sure if it's a correct way to solve this issue as this loop break has been there for ages.

My solutions is not to break the loop as there are also other dependendcies with same "groupId + artifactId" but different type.

Show
Reimo Daum added a comment - I attached possible solution for this bug - it does not break tests but i'm not sure if it's a correct way to solve this issue as this loop break has been there for ages. My solutions is not to break the loop as there are also other dependendcies with same "groupId + artifactId" but different type.

People

  • Assignee:
    Unassigned
    Reporter:
    Sébastien Cesbron
Vote (10)
Watch (10)

Dates

  • Created:
    Updated: