Details
Bug
Reopened
Critical
Description
The <scm> section of a pom in CVS for a pom archetype project looks like this prior to executing release:prepare :
<scm>
<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
</scm>
Then after executing release:prepare, the pom in CVS looks like this (new <tag> tag is only difference):
<scm>
<connection>${base.cvs.url}:commons-maven/uber-pom</connection>
<developerConnection>${base.cvs.url}:commons-maven/uber-pom</developerConnection>
<url>${base.viewcvs.url}/commons-maven/uber-pom</url>
<tag>R-1_7</tag>
</scm>
Then after executing release:perform, the pom looks like this in CVS:
<scm>
<connection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</connection>
<developerConnection>scm:cvs:pserver:behrcvs.masco-coatings.com:/usr/cvsroot:commons-maven/uber-pom</developerConnection>
<url>http://behrcvs.masco-coatings.com/cgi-bin/viewcvs.cgi/commons-maven/uber-pom</url>
</scm>
Notice that the properties that were there for the base URLs for CVS and ViewCVS have been replaced with literal values.
No other properties in the POM are being replaced
Attachments
Issue Links
| This issue is duplicated by: | ||||
| MRELEASE-325 | The release plugin does not keep the variable substitution in the connection/developer url after a release prepare/perform. |
|
|
|
| MRELEASE-487 | release:prepare mojo corrupts ${} variable reference in the <scm> tag |
|
|
|
| MRELEASE-357 | mutable CVS User |
|
|
|
| MRELEASE-342 | Can I get release plugin to not modify trunk pom's scm/connection and scm/url elements during prepare/perform? (version ok to modify) |
|
|
|
| This issue relates to: | ||||
| MRELEASE-16 | release-pom is changed too much |
|
|
|
| MRELEASE-114 | ${project.artifactId} was replaced with it's value during release:perform |
|
|
|
| MRELEASE-389 | Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform) |
|
|
|
| This issue is related to: | ||||
| MRELEASE-466 | Release plugin should preserve pom properties and ${...} variables |
|
|
|
Activity
Tested on my first release with beta-5 and the scm url is still badly updated.
Here's a patch which fixes the problems for pom.xml.next and pom.xml.tag:
MNG-128-maven-release-manager.patch
Branching is not (yet) supported.
It works like this: instead of using scm.getConnection() and scm.getDeveloperConnection() (which both contain the resolved variables), it uses the original text contained in pom.xml (using the XML element).
HOWEVER ... the tests for RewritePomsForDevelopmentPhase fail. I don't know exactly what's going on, but ... hmm, could the tests be wrong? (This is a silly assumption, I know, but ... well, I just don't know.)
Still, after patching you can install maven-release-manager with
mvn -Dmaven.test.skip=true clean install
and see if it works for you, too.
Branching is not (yet) supported.
It works like this: instead of using scm.getConnection() and scm.getDeveloperConnection() (which both contain the resolved variables), it uses the original text contained in pom.xml (using the XML element).
HOWEVER ... the tests for RewritePomsForDevelopmentPhase fail. I don't know exactly what's going on, but ... hmm, could the tests be wrong? (This is a silly assumption, I know, but ... well, I just don't know.)
Still, after patching you can install maven-release-manager with
mvn -Dmaven.test.skip=true clean install
and see if it works for you, too. Emmanuel,
I believe this is still broken in RewritePomsForDevelopmentPhase.transformScm(). The RewritePomsForReleasePhase.transformScm() works fine (note releaseConfiguration.mapOriginalScmInfo( projectId, project.getScm() )
, but values after string substitution are still used when prepping for the next development phase.
Here are changes on my pom that were committed to cvs over the prepare-perform cycle (replaced some parts with <...>)
Note the ${scm.username} is replaced with starver
<scm>
<connection>scm:cvs:ext:${scm.username}@<...></connection>
<developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
</scm>
<scm>
<connection>scm:cvs:ext:${scm.username}@<...></connection>
<developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
<tag>oss-ticket-api-1_0_29</tag>
</scm>
<scm>
<connection>scm:cvs:ext:starver@<...></connection>
<developerConnection>scm:cvs:ext:starver@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
</scm>
, but values after string substitution are still used when prepping for the next development phase.
Here are changes on my pom that were committed to cvs over the prepare-perform cycle (replaced some parts with <...>)
Note the ${scm.username} is replaced with starver
<scm>
<connection>scm:cvs:ext:${scm.username}@<...></connection>
<developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
</scm>
<scm>
<connection>scm:cvs:ext:${scm.username}@<...></connection>
<developerConnection>scm:cvs:ext:${scm.username}@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
<tag>oss-ticket-api-1_0_29</tag>
</scm>
<scm>
<connection>scm:cvs:ext:starver@<...></connection>
<developerConnection>scm:cvs:ext:starver@<...></developerConnection>
<url>http://vntwb1da.it.foo.net/cvsweb/cvsweb.cgi/<...>/oss-ticket-api/</url>
</scm> I think i found some workaround at least for the username/password issue:
First, remove the parameters from the SCM url like this:
<scm> <connection>scm:cvs:pserver:cvsserver:/home/cvs/repository/test:test</connection> </scm>
This way only works if you supply the release plugin with an username/password, like -Dusername=...
Fortunately you can set it in the build section like this:
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<configuration>
<username>${maven.scm.username}</username>
<password>${maven.scm.password}</password>
</configuration>
</plugin>
</plugins>
</build>
As the substitution only is broken inside the scm tag, this should work.
You just need to define maven.scm.username and password in your local settings and things start to look better 
<scm> <connection>scm:cvs:pserver:cvsserver:/home/cvs/repository/test:test</connection> </scm>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<configuration>
<username>${maven.scm.username}</username>
<password>${maven.scm.password}</password>
</configuration>
</plugin>
</plugins>
</build>
well a lot of plugins have this issue as well. The properties in its original form cannot be read via the plugin api (as far as i know). You can only retrieve them in the replaced way. So any plugin that rewrites the pom runs into this.
from what i know from the plugin it parses the pom.xml manually and replaces the strings 'by hand'. Which in my eyes is more tricky than one would think (depends on what part you replace with properties, your project layout, if you tag or branch or release, ...?)
But how can this be mission critical? It never 'worked' or has been this way. The release plugin (using svn in my case) needs these three lines in the scm, tabBase and branchBase are constant. In my eyes this features serves some readability in the pom and allows infrastructure changes without touching the pom files. If you do that a lot you're doomed anyway
Same for SVN. The plugin should restore the original entries in the trunk (HEAD revision) again.