Maven 2.x Release Plugin

scm.url gets translated incorrectly during release

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-beta-4
  • Fix Version/s: 2.0-beta-5
  • Component/s: scm
  • Labels:
    None
  • Number of attachments :
    0

Description

Testing release 2.0-beta4. My original scm urls are like this:
<scm>
<connection>scm:svn:http://sv1.tus.stchome.com/svn/training/products/dsms/release-branches/dsms-2.1</connection>
<developerConnection>scm:svn:http://sv1.tus.stchome.com/svn/training/products/dsms/release-branches/dsms-2.1</developerConnection>
<url>http://sv1.tus.stchome.com/viewvc/stc/products/dsms/release-branches/dsms-2.1</url>
</scm>

after the prepare, they end up like this:
<scm>
<connection>scm:svn:http://sv1.tus.stchome.com/svn/training/products/dsms/build-tags/t5</connection>
<developerConnection>scm:svn:http://sv1.tus.stchome.com/svn/training/products/dsms/build-tags/t5</developerConnection>
<url>http://sv1.tus.stchome.com/svn/training/products/dsms/build-tags/t5</url>
</scm>

Notice the url lost the viewvc reference and ended up with a direct svn url. After a release:perform, the url ends up back to viewvc so only the tag is modified.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. MRELEASE-231 Rewriting scm urls when a tagBase parameter is present.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emmanuel Venisse added a comment -

release plugin execute this method :
SvnTagBranchUtils.resolveUrl( "http://sv1.tus.stchome.com/viewvc/stc/products/dsms/release-branches/dsms-2.1", "http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags", SvnTagBranchUtils.SVN_TAGS, "t5" );

I guess you used http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags as tagBase and t5 as tag name

The result is http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags/t5

Show
Emmanuel Venisse added a comment - release plugin execute this method : SvnTagBranchUtils.resolveUrl( "http://sv1.tus.stchome.com/viewvc/stc/products/dsms/release-branches/dsms-2.1", "http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags", SvnTagBranchUtils.SVN_TAGS, "t5" ); I guess you used http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags as tagBase and t5 as tag name The result is http://sv1.tus.stchome.com/viewvc/stc/products/dsms/build-tags/t5
Hide
Permalink
Brian Fox added a comment -

This is my tag base
<tagBase>http://sv1.tus.stchome.com/svn/training/products/dsms/build-tags</tagBase>

but isn't the <url> supposed to be for human use and not scm? Seems like there needs to be a <urlBase> and then that is used to translate the url, not the tagBase.

Show
Brian Fox added a comment - This is my tag base <tagBase> http://sv1.tus.stchome.com/svn/training/products/dsms/build-tags </tagBase> but isn't the <url> supposed to be for human use and not scm? Seems like there needs to be a <urlBase> and then that is used to translate the url, not the tagBase.
Hide
Permalink
Emmanuel Venisse added a comment -

The url rewriting mustn't use resolveUrl method from SvnTagBranchUtils because this method is only for scm urls and the calcul is based only on tagBase.
The release plugin must have this own method for rewriting the url that can be totally independant of path in svn (like viewcvs urls)

Show
Emmanuel Venisse added a comment - The url rewriting mustn't use resolveUrl method from SvnTagBranchUtils because this method is only for scm urls and the calcul is based only on tagBase. The release plugin must have this own method for rewriting the url that can be totally independant of path in svn (like viewcvs urls)
Hide
Permalink
Emmanuel Venisse added a comment -

Already fixed with a test

Show
Emmanuel Venisse added a comment - Already fixed with a test

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    Brian Fox
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: