xdoc 1.9 not compatible with older customised site.jsl

Are there any news on this? Just wondering if we can still fix this for 1.9.2.

it would be nice, but I wouldn't hold off the release for it.

The navigation problem is due to the fact that the project-nav.xml generated by the 1.9+ version omits the name attribute from items. The "old" project menu items looked like this:
<item href="/mail-lists.html" name="Mailing Lists">
but the "new" items look like this
<item bundle="plugin-resources/templates/templates" href="/mail-lists.html" key="navigation.menu.item.mailing_lists">
The commons-site.jsl needs the name to be present.

The problems with generated reports appear to be similar. The generated xdocs for the team list, for example, omit names from section headings, e.g.,
<section key="template.team_list.section.title"

bundle="plugin-resources\templates\templates">

The old version had
<section name="The Team">

Here again, our jsl looks for the name attribute.

I started making changes to the commons-site.jsl to get this to work with both versions, but this got complicated. It would be great if the plugin could be patched to include the dropped attributes with default locale values.

To see all of the issues, just check out any Jakarta commons project (I have been testing with math and betwixt) along with commons-build as a peer and execute the xdoc goal. The style sheet is commons-build/commons-site.jsl.

thanks Phil. That should be reasonably easy to resolve (I think include the name and the key, and just use the key from xdoc and the name in the old jsl). Let's leave it scheduled for 1.9.2 and get that out as soon as it is rectified.

Hi Phil,
Can you test the attached patch please? I have successfully generated the site for jakarta math with it. There are a few layout differences to the published web site, so I'd like to make sure I haven't overlooked anything.

The only thing you have to do is copy the <jsl:template match="message"> template from xdoc's site.jsl into commons-site.jsl. You might want to adjust it later but it works as it is.

Side note: I have hard-coded the old (english) expressions for the name attributes into the xml templates. I think that should be ok here since it is only a backwards-compatibility fix. People writing new customized jsl's will have to do it according to the new xdoc conventions anyway (ie use 'key' instead of 'name').

I published a new snapshot for this plugin.
You can download it with :
maven plugin:download -DgroupId=maven -DartifactId=maven-xdoc-plugin -Dversion=1.9.2-SNAPSHOT -Dmaven.repo.remote=http://cvs.apache.org/repository/

Works 4 me. I checked a couple of commons sites and they all look fine, once I add the message template to commons-site.jsl. Thanks!

Note: when installing the plugin snapshot, I had to also download maven-model-3.0.1-SNAPSHOT.

Yes, I upgraded the maven-model on my machine (I'm trying to unify dependencies in all plugins) but I'm not sure we'll use it for the xdoc release or if we'll release maven-model 3.0.1 before.

do you require 3.0.1? If not, I suggest 3.0.0...

No I don't need it. I was trying to unify dependencies between plugins and between plugins and core to identify some errors due to some releases of external libs ( not simple when we use several releases of the same lib in different plugins). I'll not commit these changes now. It was just to publish the snapshot, i didn't take the time to remove my change.

Patch applied. thanks.