Maven 1.x War Plugin

war:war-resources should perform property expansion

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.6
  • Fix Version/s: 1.6.2
  • Component/s: None
  • Labels:
    None
  • Environment:
    any
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

When the war:war-resources goal is performed, resources destined for the WAR artifact are copied to ${maven.war.webapp.dir}.

It would be nice if property expansion was done during this copy such that values within resources were expanded.

A patch is attached.

Activity

Hide
Troy Poppe added a comment -

Patch to enable property expansion in war:war-resources goal.

Show
Troy Poppe added a comment - Patch to enable property expansion in war:war-resources goal.
Hide
Stephane Nicoll added a comment -

Full patch with test cases.

Show
Stephane Nicoll added a comment - Full patch with test cases.
Hide
Stephane Nicoll added a comment -

Applied with additional test cases.

Thanks.

Show
Stephane Nicoll added a comment - Applied with additional test cases. Thanks.
Hide
Arnaud Heritier added a comment -

Can we close this issue ?

Show
Arnaud Heritier added a comment - Can we close this issue ?
Hide
Stephane Nicoll added a comment -

TBR in 1.6.2 but yes, we can.

Show
Stephane Nicoll added a comment - TBR in 1.6.2 but yes, we can.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
15m
Original Estimate - 15 minutes
Remaining:
15m
Remaining Estimate - 15 minutes
Logged:
Not Specified
Time Spent - Not Specified