[#MPTEST-73] test:test goal results in double invocation of java:compile goal

Maven 1.x Test Plugin

test:test goal results in double invocation of java:compile goal

Created: 30/Jun/07 05:10 PM Updated: 02/Jul/07 05:21 AM

Component/s:

None

Affects Version/s:

1.8.2

Fix Version/s:

None

Time Tracking:

Not Specified

Environment:

All environments

Issue Links:

Supercedes

This issue supercedes:

~~MPTEST-66~~ 1.8 version introduces bug in other plugins

Description

« Hide

The test:test goal has been modified to conditionally invoke test:compile via attainGoal(test:compile). This was previously done with the prereqs attribute. Doing so caused the java:compile and all pre/post goals associated to fire twice. You can witness this behaviour even when compiling MAven 1.1 from source.

It seems unnecessary to do this for the test:test goal which conditionally skips the tests when test:compile also conditionally skips compiling. Making the same operation for test:single which intentionally omits the check for maven.test.skip makes a lot of sense.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Lukas Theussl - 01/Jul/07 02:40 AM

Did you read ~~MPTEST-66~~? If we can come up with a general solution, without spoiling ~~MPTEST-46~~, ... well, patches would be warmly welcomed.

[ Permlink | « Hide ]

Alex Volanis - 01/Jul/07 05:11 PM

I read ~~MPTEST-66~~ 5 minutes after I submitted the report

I patched the plugin to restore the previous behavior in our build environment since it was causing quite a bit of upset users having lengthy java:compile preGoals taking too much time in their builds. We have some expensive java:compile preGoals firing for every project in a mutlicomponent environment which is causing a lot of wasted time.

If the attainGoal allowed for session propagation this would have never been an issue. Why doesn't it? I am considering a patch to control this behavior globally and by tag attribute.

[ Permlink | « Hide ]

Lukas Theussl - 02/Jul/07 05:21 AM

attainGoal not using the global session is a very old bug: MAVEN-256. We probably should have fixed that for Maven 1.1...