Maven 1.x Test Plugin
  1. Maven 1.x Test Plugin
  2. MPTEST-25

maven.test.failure.ignore ignored by test:match

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      v 1.0rc1
    • Number of attachments :
      0

      Description

      Maven Dev Team,

      I've discovered that using the goal "test:match" ignores the setting of
      the property "maven.test.failure.ignore" whereas "test:test" abides by
      the setting properly.

      I was able to fix it in the maven-test-plugin-1.4/plugin.jelly file of
      my
      environment by using the line as stated in the test:test goal:
      failureProperty="maven.test.failure"
      and eliminating the hardcoded "halt on failure stuff". Here's the diff:

      190,191c190
      < haltonfailure="yes"
      < haltonerror="yes"

      > failureProperty="maven.test.failure"
      254,255c253
      < haltonfailure="yes"
      < haltonerror="yes"

      > failureProperty="maven.test.failure"

        Activity

        Hide
        Brett Porter added a comment -

        fixed. please be careful with patches - this one caused it never to fail because it isn't checking the failure property.

        Also, patches should be attached, not inline, and should be in unified diff format (-u)

        Show
        Brett Porter added a comment - fixed. please be careful with patches - this one caused it never to fail because it isn't checking the failure property. Also, patches should be attached, not inline, and should be in unified diff format (-u)

          People

          • Assignee:
            Brett Porter
            Reporter:
            david swierczek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5 minutes
              5m
              Remaining:
              Remaining Estimate - 5 minutes
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified