after the patch for MPSITE-28 (Maven site 1.6.1 plugin always results in 'Build Successful') now sshdeploy fails for any "minor" error: for example if tar can't overwrite a file or if the remote user doesn't have the needed rights to change the permission for the root site directory (which is pretty common, like for the htdocs dir on sourceforge).
This is also more annoying considering that an incomplete deploy can leave a remote *.tar file, which by default is not overwritten and that will make any further build fail till manually removed.
for refence, this is the patch previously applied by Arnaud:
http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/site/plugin.jelly?rev=202438&r1=189828&r2=202438&diff_format=h
what about leaving the "failonerror" parameter in last snippet to "false" or at least making it configurable?
<exec dir="." executable="${maven.ssh.executable}" failonerror="true"> <------ will make the build fail if any of the commands will report an "innocent" error
<arg line="${maven.ssh.args} -l ${siteUsername} ${siteAddress} 'cd ${maven.homepage} &&
${maven.site.gunzip.executable} ${maven.final.name}-site.tar.gz && ${maven.site.tar.executable}
${maven.site.tar.options} ${maven.final.name}-site.tar && chmod -Rf g+u * . && rm
${maven.final.name}-site.tar'"/>
</exec>
MPSITE-28can't be the root cause of this problem if you are using the release 1.6.1. This patch was applied on the 1.6.2 which is not yet released.