Issue Details (XML | Word | Printable)

Key: MPSITE-34
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: fabrizio giustina
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Maven 1.x Site Plugin

site:sshdeploy now always fails for any remote error

Created: 01/Aug/05 02:58 PM   Updated: 22/Oct/05 10:20 PM   Resolved: 22/Oct/05 10:20 PM
Return to search
Component/s: plugin
Affects Version/s: 1.7
Fix Version/s: 1.7

Time Tracking:
Not Specified

Issue Links:
dependent
 


 Description  « Hide

after the patch for MPSITE-28 (Maven site 1.6.1 plugin always results in 'Build Successful') now sshdeploy fails for any "minor" error: for example if tar can't overwrite a file or if the remote user doesn't have the needed rights to change the permission for the root site directory (which is pretty common, like for the htdocs dir on sourceforge).
This is also more annoying considering that an incomplete deploy can leave a remote *.tar file, which by default is not overwritten and that will make any further build fail till manually removed.

for refence, this is the patch previously applied by Arnaud:
http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/site/plugin.jelly?rev=202438&r1=189828&r2=202438&diff_format=h

what about leaving the "failonerror" parameter in last snippet to "false" or at least making it configurable?

<exec dir="." executable="${maven.ssh.executable}" failonerror="true"> <------ will make the build fail if any of the commands will report an "innocent" error
<arg line="${maven.ssh.args} -l ${siteUsername} ${siteAddress} 'cd ${maven.homepage} &&
${maven.site.gunzip.executable} ${maven.final.name}-site.tar.gz && ${maven.site.tar.executable}
${maven.site.tar.options} ${maven.final.name}-site.tar && chmod -Rf g+u * . && rm
${maven.final.name}-site.tar'"/>
</exec>



Arnaud Heritier added a comment - 01/Aug/05 04:08 PM

MPSITE-28 can't be the root cause of this problem if you are using the release 1.6.1. This patch was applied on the 1.6.2 which is not yet released.


fabrizio giustina added a comment - 02/Aug/05 02:28 AM

You are right, I am using 1.6.2 snapshot compiled from svn, not 1.6.1


Arnaud Heritier added a comment - 02/Aug/05 02:45 AM

More logical. It's a problem in 1.6.2 due to MPSITE-28


Arnaud Heritier added a comment - 22/Oct/05 10:20 PM

New property maven.site.failonerror can be used bypass remote errors.