Maven 1.x Site Plugin

SSH deployment can mess up file permissions of home dir

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.5.2
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    site:sshdeploy on UNIX site.
  • Number of attachments :
    0

Description

site:sshdeploy can mess up home rights if part of the commands fail.
Remote command chain like "...;cd BLA;chmod ..." should be conditionally executed if the "cd" succeeds. That way, if one command fails the others (like chmod) do not get executed in the wrong directory.

Can lead to fatal consequences for eg ssh resource dir (.ssh) with wrong
permissions, oops.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jörg Schaible added a comment -

Happened to me also some weeks ago and lately to my collegue. IHMO "major" does not classify this issue.

Show
Jörg Schaible added a comment - Happened to me also some weeks ago and lately to my collegue. IHMO "major" does not classify this issue.
Hide
Permalink
Marcel May added a comment -

It is severe as it is a security risk and got me ssh locked out of
the site server (not nice when you do not sit beside the machine).

It is not a major issue if considering that the plugin does perform
its job, if not badly configured with wrong site dir

I propose to set the "failonerror" to true, at least for ssh copying
the stuff to the site. That way, the site deploy will terminate
if something is wrong...

Show
Marcel May added a comment - It is severe as it is a security risk and got me ssh locked out of the site server (not nice when you do not sit beside the machine). It is not a major issue if considering that the plugin does perform its job, if not badly configured with wrong site dir I propose to set the "failonerror" to true, at least for ssh copying the stuff to the site. That way, the site deploy will terminate if something is wrong...
Hide
Permalink
Trygve Laugstøl added a comment -

Simply replacing ";" with "&&" should do the trick.

Show
Trygve Laugstøl added a comment - Simply replacing ";" with "&&" should do the trick.
Hide
Permalink
Lukas Theussl added a comment -

Just wanted to fix it and found it had been done already (revision 164292).

Show
Lukas Theussl added a comment - Just wanted to fix it and found it had been done already (revision 164292).

People

  • Assignee:
    Unassigned
    Reporter:
    Marcel May
Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: