Simian report contains broken links

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.6
Labels:
None
Environment:
Maven 1.0, Java 1.4.2, all platforms.

Number of attachments :
1

Description

Reports generated through the simian maven plugin contain broken links for all entries in the "duplications" section. Please see simian report on my site:

http://jexus.sourceforge.net/simian-report.html

I have seen this in other maven project sites with simian reports.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

patchforsimian.txt

23/Aug/05 12:36 PM

4 kB

Jim Dickinson

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Eric Pugh added a comment - 08/Jul/05 4:12 PM

Can you retest with the recently updated version 1.5-SNAPSHOT? I am hoping the switch to simian.jsl will have fixed this.

Show

David Eric Pugh added a comment - 08/Jul/05 4:12 PM Can you retest with the recently updated version 1.5-SNAPSHOT? I am hoping the switch to simian.jsl will have fixed this.

Hide

Permalink

Jim Dickinson added a comment - 22/Aug/05 2:44 PM

I have this problem also... all of the links contain 'xref-test' where they should only contain 'xref'...

The problem appears to be somewhere in these lines of simian.jsl (96-136)...

<j:forEach var="duplicationArea" items="$

{blocks}

<j:set var="name" value="$

{duplicationArea.attribute('sourceFile').getValue()}

"/>

<j:set var="srcDirLength" value="$

{srcDir.length() + 1}

"/>

<j:set var="testDirLength" value="$

{testDir.length() + 1}

"/>

<j:set var="testIndex" value="$

{name.lastIndexOf(testDir)}

"/>

<j:choose>

<j:when test="$

{testIndex > 0}">

<j:set var="name" value="${name.substring(mavenTool.toInteger(testDirLength.toString()))}"/>

</j:when>

<j:otherwise>

<j:set var="name" value="${name.substring(mavenTool.toInteger(srcDirLength.toString()))}"/>

</j:otherwise>

</j:choose>

<j:set var="lastIndex" value="${name.lastIndexOf('.java')}"/>

<j:choose>

<j:when test="${lastIndex > 0}">

<j:set var="index" value="${mavenTool.toInteger(lastIndex.toString())}"/>

<j:set var="nameWithoutJavaExtension" value="${name.substring(0, index)}"/>

<util:replace var="nameWithoutJavaExtension" value="${nameWithoutJavaExtension}" oldChar="
" newChar="/"/>

<j:choose>

<j:when test="${testIndex > 0}

<li><a href="xref/$

{nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}

( $

{duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

</j:when>

<j:otherwise>

<li><a href="xref-test/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}

">$

{nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

</j:otherwise>

</j:choose>

</j:when>

<j:otherwise>

<j:choose>

<j:when test="${testIndex > 0}">

<li><a href="xref/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension}

( $

{duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li>

</j:when>

<j:otherwise>

<li><a href="xref-test/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}

">$

{nameWithoutJavaExtension}

( $

{duplicationArea.attribute('startLineNumber').getValue()}

- $

{duplicationArea.attribute('endLineNumber').getValue()}

)</a></li>

</j:otherwise>

</j:choose>

</j:otherwise>

</j:choose>

</j:forEach>

This is with the released 1.5 simian plug-in. It looks like the logic is wrong, or testIndex is not being set correctly (i.e. true when it should be false).

Show

Jim Dickinson added a comment - 22/Aug/05 2:44 PM I have this problem also... all of the links contain 'xref-test' where they should only contain 'xref'... The problem appears to be somewhere in these lines of simian.jsl (96-136)... <j:forEach var="duplicationArea" items="$ {blocks} "> <j:set var="name" value="$ {duplicationArea.attribute('sourceFile').getValue()} "/> <j:set var="srcDirLength" value="$ {srcDir.length() + 1} "/> <j:set var="testDirLength" value="$ {testDir.length() + 1} "/> <j:set var="testIndex" value="$ {name.lastIndexOf(testDir)} "/> <j:choose> <j:when test="$ {testIndex > 0}"> <j:set var="name" value="${name.substring(mavenTool.toInteger(testDirLength.toString()))}"/> </j:when> <j:otherwise> <j:set var="name" value="${name.substring(mavenTool.toInteger(srcDirLength.toString()))}"/> </j:otherwise> </j:choose> <j:set var="lastIndex" value="${name.lastIndexOf('.java')}"/> <j:choose> <j:when test="${lastIndex > 0}"> <j:set var="index" value="${mavenTool.toInteger(lastIndex.toString())}"/> <j:set var="nameWithoutJavaExtension" value="${name.substring(0, index)}"/> <util:replace var="nameWithoutJavaExtension" value="${nameWithoutJavaExtension}" oldChar=" " newChar="/"/> <j:choose> <j:when test="${testIndex > 0} "> <li><a href="xref/$ {nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( $ {duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li> </j:when> <j:otherwise> <li><a href="xref-test/${nameWithoutJavaExtension}.html#${duplicationArea.attribute('startLineNumber').getValue()} ">$ {nameWithoutJavaExtension} ( ${duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li> </j:otherwise> </j:choose> </j:when> <j:otherwise> <j:choose> <j:when test="${testIndex > 0}"> <li><a href="xref/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()}">${nameWithoutJavaExtension} ( $ {duplicationArea.attribute('startLineNumber').getValue()} - ${duplicationArea.attribute('endLineNumber').getValue()} )</a></li> </j:when> <j:otherwise> <li><a href="xref-test/${name}.html#${duplicationArea.attribute('startLineNumber').getValue()} ">$ {nameWithoutJavaExtension} ( $ {duplicationArea.attribute('startLineNumber').getValue()} - $ {duplicationArea.attribute('endLineNumber').getValue()} )</a></li> </j:otherwise> </j:choose> </j:otherwise> </j:choose> </j:forEach> This is with the released 1.5 simian plug-in. It looks like the logic is wrong, or testIndex is not being set correctly (i.e. true when it should be false).

Hide

Permalink

Jim Dickinson added a comment - 23/Aug/05 12:36 PM

This patch contains a fix to the problem described above. I think the problem is as simple as an incorrect ordering of statements.

Show

Jim Dickinson added a comment - 23/Aug/05 12:36 PM This patch contains a fix to the problem described above. I think the problem is as simple as an incorrect ordering of statements.

Hide

Permalink

David Eric Pugh added a comment - 12/Sep/05 1:05 PM

I found that the jelly line: <j:when test="$

{testIndex > 0}

"> needed to be <j:when test="$

{testIndex > -1}

"> as well.

Show

David Eric Pugh added a comment - 12/Sep/05 1:05 PM I found that the jelly line: <j:when test="$ {testIndex > 0} "> needed to be <j:when test="$ {testIndex > -1} "> as well.

Hide

Permalink

Arnaud Heritier added a comment - 27/Oct/05 3:26 PM

Seems to be fixed by David.

Show

Arnaud Heritier added a comment - 27/Oct/05 3:26 PM Seems to be fixed by David.

People

Assignee:

David Eric Pugh

Reporter:

Ricardo Gladwell

Vote (0)

Watch (1)

Dates

Created:

05/Oct/04 7:49 AM

Updated:

27/Oct/05 3:26 PM

Resolved:

12/Sep/05 1:05 PM