Maven 1.x SCM Plugin

It should be possible to check changes made by prepare-release before they are checked in and tagged

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.6
  • Labels:
    None
  • Environment:
    m11b3, scm plugin
  • Number of attachments :
    0

Description

See MRELEASE-77 for the equivalent m2 problem.

Currently, the scm:prepare-release goal modifies the files project.xml and changes.xml, then commits the changes and tags the entire source tree, all in one step. If there is a problem with updating the files, we have a faulty version checked in and tagged in the repository. And usually, there are problems (see MPSCM-1, MPSCM-12, MPSCM-43, MPSCM-67, ...?).

Given this immature state of the plugin, I think it is necessary that we provide the possibility to undo any unwanted modifications before anything gets checked in and tagged. I'm just not sure about the best way to do that:

  • move the check-in and tagging into the scm:perform-release goal, so prepare release only updates project.xml and changes.xml
  • add a new goal for updating project.xml and changes.xml
  • add a property 'testmode' like in m2, that skips the check-in and tagging (not sure how that would help when there are problems though)

I'd prefer the second choice, what do others think?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Arnaud Heritier added a comment -

I'm agree to have a new goal to allow us to see what is changed.
We can add this goal as a prerequisite for the tag scm:prepare-release, thus it's transparent .

Show
Arnaud Heritier added a comment - I'm agree to have a new goal to allow us to see what is changed. We can add this goal as a prerequisite for the tag scm:prepare-release, thus it's transparent .
Hide
Permalink
Lukas Theussl added a comment -

I finally opted for a new property maven.scm.testmode (default: false) which was easier to implement (otherwise we would have had to check whether the same tag and version were used in different goals). It's also more similar to the m2 behavior.

Show
Lukas Theussl added a comment - I finally opted for a new property maven.scm.testmode (default: false) which was easier to implement (otherwise we would have had to check whether the same tag and version were used in different goals). It's also more similar to the m2 behavior.

People

  • Assignee:
    Unassigned
    Reporter:
    Lukas Theussl
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: