Maven 1.x SCM Plugin

When pom.repository.connection ends with " /" checkout fails (patch)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.6
  • Labels:
    None
  • Number of attachments :
    1

Description

When pom.repository.connection includes a terminating /, the generated URL for checkouts is incorrect. For example, if pom.repository.connection is "http://svn.apache.org/repos/asf/maven/maven-1/core/trunk/" then
maven scm:checkout -Dmaven.scm.tag=MAVEN_1_0_2
results in a (failed) attempt to check out https://svn.apache.org/repos/asf/maven/maven-1/core/trunk/tags/MAVEN_1_0_2

The attached patch works around this problem, but is a little ugly, since what really should be patched is the parseUrl method in o.a.m.scm.provider.svn.repository.ScmProviderRepository.

This problem also affects the JDiff plugin (1.5) which uses the scm tag library.

Activity

Hide
Permalink
Lukas Theussl added a comment -

Patch applied. Thanks!

Show
Lukas Theussl added a comment - Patch applied. Thanks!

People

  • Assignee:
    Unassigned
    Reporter:
    Phil Steitz
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: