Maven 1.x RAR Plugin
  1. Maven 1.x RAR Plugin
  2. MPRAR-1

plugin properties are not used correctly

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Labels:
      None
    • Number of attachments :
      1

      Description

      The rar plugin defines many variables:

      maven.rar.src=$

      {maven.src.dir}

      /rar
      maven.rar.descriptordir=$

      {maven.rar.src}

      /META-INF
      maven.rar.raxml=$

      {maven.rar.descriptordir}/ra.xml
      maven.rar.manifest=${maven.rar.descriptordir}

      /MANIFEST.MF
      maven.rar.displayname=$

      {pom.id}

      maven.rar.resources=$

      {maven.build.dir}

      /rar

      But some of them are ignored. For instance, the descriptordir is not used and the only reference to the raxml is inside an echo tag:
      <ant:echo>Building rar $

      {maven.final.name}

      with ra.xml "$

      {maven.rar.raxml}

      "</ant:echo>

      In other words, the way it is now, the ra.xml must be inside the directory defined by maven.rar.src, otherwise it won't be included, even if the raxml or descriptordir is defined (and that's really bad).

        Activity

        Hide
        Axel Mueller added a comment -

        I have fixed the plugin to use maven.rar.descriptordir properly.

        Show
        Axel Mueller added a comment - I have fixed the plugin to use maven.rar.descriptordir properly.
        Hide
        Brett Porter added a comment -

        Axel, this patch doesn't look like it'll work to me unless maven.rar.descriptor.dir = META-INF which defeats the purpose.

        Show
        Brett Porter added a comment - Axel, this patch doesn't look like it'll work to me unless maven.rar.descriptor.dir = META-INF which defeats the purpose.
        Hide
        Stéphane Nicoll added a comment -

        This is fixed, ra.xml file is now included wherever it is located.

        Show
        Stéphane Nicoll added a comment - This is fixed, ra.xml file is now included wherever it is located.
        Hide
        Felipe Leme added a comment -

        Stephane,

        Could you please add a small test case for this issue (and also MPRAR-2)? I know the rar plugin does not have any testcase yet, but you could use other plugins (such as the maven-ear-plugin) as template...

        – Felipe

        (PS: my maven environment is messed up right now, otherwise I would add such testcases myself...)

        Show
        Felipe Leme added a comment - Stephane, Could you please add a small test case for this issue (and also MPRAR-2 )? I know the rar plugin does not have any testcase yet, but you could use other plugins (such as the maven-ear-plugin) as template... – Felipe (PS: my maven environment is messed up right now, otherwise I would add such testcases myself...)

          People

          • Assignee:
            Stéphane Nicoll
            Reporter:
            Felipe Leme
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 hour
              1h
              Remaining:
              Remaining Estimate - 1 hour
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified