Maven 1.x NSIS Plugin

Plugin continues even if makensis returns an error

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 2.0
  • Labels:
    None
  • Number of attachments :
    0

Description

The plugin does not stop the build if makensis returns an error (ie. exit code 1 on windows platforms.)
This could easily be achieved by adding failonerror=true to the $

{maven.nsis.exe}

invocation at line #86.

Activity

Hide
Permalink
dion gillard added a comment -

Added failonerror

Show
dion gillard added a comment - Added failonerror

People

  • Assignee:
    dion gillard
    Reporter:
    Matthias Kerkhoff
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
15m
Original Estimate - 15 minutes
Remaining:
15m
Remaining Estimate - 15 minutes
Logged:
Not Specified
Time Spent - Not Specified