Maven 2.x PMD Plugin

verbose output not useful for inner classes

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.4
  • Component/s: PMD
  • Labels:
    None
  • Number of attachments :
    1

Description

With verbose output on, a pmd error in an inner class will produce output like,

[INFO] PMD Failure: foo.bar.Anonymous$1:182 Rule:SignatureDeclareThrowsException Priority:3 A method/constructor shouldn't explicitly throw java.lang.Exception.

Rather than printing the class name, it would be more useful to print out the file name.

Issue Links

depends upon

Task - A task that needs to be done. MPMD-78 Update to PMD 4.2.1

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Xavier Le Vourch added a comment -

This is really an issue with the xml format in pmd. It's not giving the correct info for inner classes, whether they're anonymous or not as the enclosing class name is not part of the report. I'll fix it in pmd itself.

Show
Xavier Le Vourch added a comment - This is really an issue with the xml format in pmd. It's not giving the correct info for inner classes, whether they're anonymous or not as the enclosing class name is not part of the report. I'll fix it in pmd itself.
Hide
Permalink
Xavier Le Vourch added a comment -

I created a bug report for pmd at:

http://sourceforge.net/tracker/index.php?func=detail&aid=1842505&group_id=56262&atid=479921

so that the fix can be tracked here.

Show
Xavier Le Vourch added a comment - I created a bug report for pmd at: http://sourceforge.net/tracker/index.php?func=detail&aid=1842505&group_id=56262&atid=479921 so that the fix can be tracked here.
Hide
Permalink
Xavier Le Vourch added a comment - - edited

The just released pmd 4.2 fixes this problem as the inner classes names are not correctly generated in the xml reports.

Updating the pmd-jdk14 version required in pom.xml to 4.2 is all that's needed...

Xavier

Show
Xavier Le Vourch added a comment - - edited The just released pmd 4.2 fixes this problem as the inner classes names are not correctly generated in the xml reports. Updating the pmd-jdk14 version required in pom.xml to 4.2 is all that's needed... Xavier
Hide
Permalink
Benjamin Bentmann added a comment -

I've updated the plugin's dependency on PMD to 4.2.1 (MPMD-78), so this should be fixed. Unfortunately, I can't deploy a new snapshot for users to test right now due to permission problems.

Show
Benjamin Bentmann added a comment - I've updated the plugin's dependency on PMD to 4.2.1 ( MPMD-78 ), so this should be fixed. Unfortunately, I can't deploy a new snapshot for users to test right now due to permission problems.
Hide
Permalink
Benjamin Bentmann added a comment -

OK, the new snapshot is up (2.4-20080419.112201-2).

Show
Benjamin Bentmann added a comment - OK, the new snapshot is up (2.4-20080419.112201-2).
Hide
Permalink
Benjamin Bentmann added a comment -

With PMD 4.2.1, I observe the following output

[INFO] [pmd:check {execution: default}]
[INFO] PMD Failure: org.Main$LocalClass:10 ...
[INFO] PMD Failure: org.Main:15 ...
[INFO] PMD Failure: org.Main$InnerClass:22 ...

i.e. the top-level class and the line number are properly given, so thanks to Xavier for his work over on PMD!

Show
Benjamin Bentmann added a comment - With PMD 4.2.1, I observe the following output [INFO] [pmd:check {execution: default}] [INFO] PMD Failure: org.Main$LocalClass:10 ... [INFO] PMD Failure: org.Main:15 ... [INFO] PMD Failure: org.Main$InnerClass:22 ... i.e. the top-level class and the line number are properly given, so thanks to Xavier for his work over on PMD!

People

  • Assignee:
    Benjamin Bentmann
    Reporter:
    Sean Bridges
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: