Maven 2.x PMD Plugin

Upgrade to PMD 4.1

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

PMD 3.9 has a serious bug when trying to create a report of Java 1.5 classes with @SuppressWarnings annotations.
Hopefully, an update would fix this bug.

  1. Text File
    patch.txt
    20/Nov/07 5:01 PM
    2 kB
    Nick Stolwijk
  2. Text File
    pmd41_patch.txt
    27/Nov/07 1:52 AM
    1 kB
    Xavier Le Vourch

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Russ Carver added a comment -

Anyone here of a fix yet? We are having to turn off PMD until it's fixed.

Show
Russ Carver added a comment - Anyone here of a fix yet? We are having to turn off PMD until it's fixed.
Hide
Permalink
Travis Fielding added a comment -

PMD is now at version 4.1.

Show
Travis Fielding added a comment - PMD is now at version 4.1.
Hide
Permalink
Russ Carver added a comment -

Great! Is this the PMD bundled with Maven? Or just PMD itself? And has this report generation exception fix been verified?

Show
Russ Carver added a comment - Great! Is this the PMD bundled with Maven? Or just PMD itself? And has this report generation exception fix been verified?
Hide
Permalink
Travis Fielding added a comment -

Hey Russ, I was just referring to the fact that PMD 4.1 itself has been released. Unfortunately, I don't think there has been any work started on the plugin in regards to this one yet. Wish I had better news

Show
Travis Fielding added a comment - Hey Russ, I was just referring to the fact that PMD 4.1 itself has been released. Unfortunately, I don't think there has been any work started on the plugin in regards to this one yet. Wish I had better news
Hide
Permalink
Nick Stolwijk added a comment -

PMD 4.1 has been released to central, but unfortunately without a pom file. Also, there isn't a lot of activity on the maven-pmd-plugin trunk lately. Is it still under development? Daniel Kulp was the main committer, is he still around?

Show
Nick Stolwijk added a comment - PMD 4.1 has been released to central, but unfortunately without a pom file. Also, there isn't a lot of activity on the maven-pmd-plugin trunk lately. Is it still under development? Daniel Kulp was the main committer, is he still around?
Hide
Permalink
Nick Stolwijk added a comment -

Oh, and the deployed PMD 4.1 jar file is compiled with Java 5 instead of 1.4.

Show
Nick Stolwijk added a comment - Oh, and the deployed PMD 4.1 jar file is compiled with Java 5 instead of 1.4.
Hide
Permalink
Nick Stolwijk added a comment -

I've upped the version of PMD to 4.1 and removed the special cases for Jaxen and Xom, because the new PMD-4.1 POM (not in repository yet) includes the right jaxen (1.1).

Also, be very wary of xom-1.1 as it contains some outdated classes from Jaxen!

Show
Nick Stolwijk added a comment - I've upped the version of PMD to 4.1 and removed the special cases for Jaxen and Xom, because the new PMD-4.1 POM (not in repository yet) includes the right jaxen (1.1). Also, be very wary of xom-1.1 as it contains some outdated classes from Jaxen!
Hide
Permalink
Nick Stolwijk added a comment -

The POM file for 4.1 is also in the repository.

Show
Nick Stolwijk added a comment - The POM file for 4.1 is also in the repository.
Hide
Permalink
Xavier Le Vourch added a comment -

I've reopened my pmd upload request to fix the pom file for 4.1 as the jaxen and junit dependencies are incorrect.

So in the short term, a jaxen exclusion is still needed to make sure 1.1.1 is used as some XPath rules will crash pmd otherwise.

I've uploaded an updated version of the patch. From my limited tests, it seems to be working fine with 4.1 so far.

I'll make sure the pom file is correct in future releases of pmd...

Xavier

Show
Xavier Le Vourch added a comment - I've reopened my pmd upload request to fix the pom file for 4.1 as the jaxen and junit dependencies are incorrect. So in the short term, a jaxen exclusion is still needed to make sure 1.1.1 is used as some XPath rules will crash pmd otherwise. I've uploaded an updated version of the patch. From my limited tests, it seems to be working fine with 4.1 so far. I'll make sure the pom file is correct in future releases of pmd... Xavier
Hide
Permalink
Daniel Kulp added a comment -

Xavier - applying the patch cases the new tests for MPMD-55 to fail. It's generating an XML file with charset ANSI_X3.4-1968 which is apparently not supported on my machine.

Show
Daniel Kulp added a comment - Xavier - applying the patch cases the new tests for MPMD-55 to fail. It's generating an XML file with charset ANSI_X3.4-1968 which is apparently not supported on my machine.
Hide
Permalink
Xavier Le Vourch added a comment -

this does not seem to be related to the update to 4.1 as I'm getting the test error on the current plugin code from svn which still uses pmd 3.9 and the tests worked on my machine prior to MPMD-55 being committed.

It looks like it's something wrong with MPMD-55 but I'll look at it today and try to see what's wrong.

Xavier

Show
Xavier Le Vourch added a comment - this does not seem to be related to the update to 4.1 as I'm getting the test error on the current plugin code from svn which still uses pmd 3.9 and the tests worked on my machine prior to MPMD-55 being committed. It looks like it's something wrong with MPMD-55 but I'll look at it today and try to see what's wrong. Xavier
Hide
Permalink
Xavier Le Vourch added a comment -

I've submitted a fix to MPMD-55 that corrects the problem and the update to 4.1 should now work, at least it works on my machine...

Show
Xavier Le Vourch added a comment - I've submitted a fix to MPMD-55 that corrects the problem and the update to 4.1 should now work, at least it works on my machine...
Hide
Permalink
Daniel Kulp added a comment -

Patch applied. Tests are now passing.

Show
Daniel Kulp added a comment - Patch applied. Tests are now passing.

People

  • Assignee:
    Daniel Kulp
    Reporter:
    Ulli Hafner
Vote (8)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: