Maven 2.x PMD Plugin

The Xml pmd file isn't encode to UTF8 charset counter the charset declaration in the file header

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.3
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

The Xml file (target/pmd.xml) declare an UTF-8 encoding: "<?xml version="1.0" encoding="UTF-8"?>" but use the FileWriter API that encode caracter with the default charset of the platform.
Non ACSII caracter couldn't be read and xml file couldn't be parsed with Xml Parser due to this error.

The patch contains the testcode and the correction

  1. Text File
    PMD-UTF8-Encode.patch
    29/May/07 2:48 AM
    10 kB
    Philippe Kernevez
  2. Text File
    MPMD-55-FIX.TXT
    29/Nov/07 3:09 PM
    0.5 kB
    Xavier Le Vourch

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MPMD-83 Use proper file encoding for Non-HTML reports

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Philippe Kernevez added a comment -

Is there some activity on this plugin ?
How can we progress on this issue and release a new version ?

Show
Philippe Kernevez added a comment - Is there some activity on this plugin ? How can we progress on this issue and release a new version ?
Hide
Permalink
John Allen added a comment - - edited

Just encountered this ourselves, will try patch locally

Show
John Allen added a comment - - edited Just encountered this ourselves, will try patch locally
Hide
Permalink
Daniel Kulp added a comment -

Patch applied, thanks!

Show
Daniel Kulp added a comment - Patch applied, thanks!
Hide
Permalink
Xavier Le Vourch added a comment -

The patch has been committed but the tests fail.

The reason is that there is a side effect in the new testWriteNonHtml() test when creating TokenEntry objects.

My patch fixes that by calling go() on the CPD object to reset the CPD state. With it, all tests pass whether using PMD 3.9 or PMD 4.1 once MPMD-59 is applied.

Show
Xavier Le Vourch added a comment - The patch has been committed but the tests fail. The reason is that there is a side effect in the new testWriteNonHtml() test when creating TokenEntry objects. My patch fixes that by calling go() on the CPD object to reset the CPD state. With it, all tests pass whether using PMD 3.9 or PMD 4.1 once MPMD-59 is applied.

People

  • Assignee:
    Daniel Kulp
    Reporter:
    Philippe Kernevez
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: