Maven 2.x Plugin Tools

Support includes/excludes

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: API, Plugin Plugin
  • Labels:
    None
  • Number of attachments :
    1

Description

Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.

This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).

If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.

Any suggestions?

[1] MPLUGIN-1
[2] QDOX-94

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MPLUGIN-1 Maven fails while developing plugin with 1.5 compliant sources

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Task - A task that needs to be done. MPLUGIN-110 Make easier to pass parameters into MojoDescriptorExtractors

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Jochen Kuhnle made changes -
Field Original Value New Value
Link This issue depends upon MPLUGIN-1 [ MPLUGIN-1 ]
Dennis Lundberg made changes -
Description Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.

This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).

If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.

Any suggestions?

[1] http://jira.codehaus.org/browse/MPLUGIN-1
[2] http://jira.codehaus.org/browse/QDOX-94 		Support advanced scanner configuration (e.g. includes/excludes), just like the compiler plugin does. This allows to restrict the sources the plugin scans, rationale see compiler plugin.

This also would help working around QDOX not supporting JDK 1.5 (see [1] and [2]).

If this is wanted and somebody tells me the best way, I'll gladly implement it. I looked at the code and noticed a "brute force" approach would mean adding the scanner configuration to the plugin MOJO and propagating it through MojoScanner.populatePluginDescriptor and MojoDescriptorExtractor.execute (changing the intefaces). Does not sound like the best option... The next thing would be to add the configuration to PluginDescriptor (maybe other plugins might want to use this feature, too..). The third option would be to add it to some component manager that is available, but escaped me while looking at the code.

Any suggestions?

[1] MPLUGIN-1
[2] QDOX-94
Benjamin Bentmann made changes -
Link This issue depends upon MPLUGIN-110 [ MPLUGIN-110 ]
Benjamin Bentmann made changes -
Component/s Plugin Plugin [ 13021 ]
Component/s API [ 13118 ]
Hide
Permalink
Leon Franzen added a comment -

Maven plugin include/excludes configuration

Show
Leon Franzen added a comment - Maven plugin include/excludes configuration
Leon Franzen made changes -
Attachment trunk.patch [ 59380 ]
Hide
Permalink
Leon Franzen added a comment - - edited

We have a peculiar case where our source control system creates src directories where the source files are each symlinks into a subdirectories that should be hidden by virtue of the fact they start with a dot ("."). Because the maven-plugin-plugin matches the symlink plus the linked-to hidden source, it causes the default configuration of the maven-plugin-plugin to attempt to parse two of every source file. The QDOX parser doesn't appreciate the duplication and fails.

I've attached a patch based on trunk rev 1305952 to allow optional specification of includes and excludes patterns. It works for the script and Java extractor implementations. Default configuration should behave exactly as before. Specification of includes element will override the default behavior. Please let me know if my fix is not acceptable in any way and I'll try to make appropriate changes.

Show
Leon Franzen added a comment - - edited We have a peculiar case where our source control system creates src directories where the source files are each symlinks into a subdirectories that should be hidden by virtue of the fact they start with a dot ("."). Because the maven-plugin-plugin matches the symlink plus the linked-to hidden source, it causes the default configuration of the maven-plugin-plugin to attempt to parse two of every source file. The QDOX parser doesn't appreciate the duplication and fails. I've attached a patch based on trunk rev 1305952 to allow optional specification of includes and excludes patterns. It works for the script and Java extractor implementations. Default configuration should behave exactly as before. Specification of includes element will override the default behavior. Please let me know if my fix is not acceptable in any way and I'll try to make appropriate changes.

People

  • Assignee:
    Unassigned
    Reporter:
    Jochen Kuhnle
Vote (5)
Watch (3)

Dates

  • Created:
    Updated: