Maven 2.x Plugin Tools

plugin report broken in 2.4

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.4.1
  • Component/s: Plugin Plugin
  • Labels:
    None
  • Number of attachments :
    0

Description

In 2.4 with 2.0.8 I get:

[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] org.apache.maven.doxia.siterenderer.Renderer.createSink(Ljava/io/File;Ljava/lang/String;)Lorg/apache/maven/doxia/siterenderer/sink/SiteRendererSink;
[INFO] ------------------------------------------------------------------------
[DEBUG] Trace
java.lang.NoSuchMethodError: org.apache.maven.doxia.siterenderer.Renderer.createSink(Ljava/io/File;Ljava/lang/String;)Lorg/apache/maven/doxia/siterenderer/sink/SiteRendererSink;
	at org.apache.maven.reporting.AbstractMavenReport.execute(AbstractMavenReport.java:63)
	at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:447)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:493)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:463)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:282)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:324)
	at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
	at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
	at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
	at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

Issue Links

Activity

Hide
Brian Fox added a comment -

I added an IT to reproduce this here: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk/maven-plugin-plugin/src/it

Notice that the IT first calls the report version 2.3 and it works. Report version 2.4 then fails on the same project.

Show
Brian Fox added a comment - I added an IT to reproduce this here: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk/maven-plugin-plugin/src/it Notice that the IT first calls the report version 2.3 and it works. Report version 2.4 then fails on the same project.
Hide
Benjamin Bentmann added a comment - - edited

Somehow this stack trace looks familar: MCHANGES-88.

Dennis had the same problem with the l10n-plugin over at Mojo and could "cure" it by downgrading to doxia 1.0-alpha-7, see plugin's promotion vote.

Maybe a newer release of the maven-reporting-impl is due to catch up with doxia.

Show
Benjamin Bentmann added a comment - - edited Somehow this stack trace looks familar: MCHANGES-88. Dennis had the same problem with the l10n-plugin over at Mojo and could "cure" it by downgrading to doxia 1.0-alpha-7, see plugin's promotion vote. Maybe a newer release of the maven-reporting-impl is due to catch up with doxia.
Hide
John Casey added a comment -

I think this is related to a piece of code that was originally duplicated in the site mojo, which takes care of constructing a sink from the site renderer component...these two (multiple?) copies diverged as time went on, and now the site run including the plugin-plugin succeeds because it constructs and passes in a sink, where the plugin:report execution fails.

That's just a theory.

Show
John Casey added a comment - I think this is related to a piece of code that was originally duplicated in the site mojo, which takes care of constructing a sink from the site renderer component...these two (multiple?) copies diverged as time went on, and now the site run including the plugin-plugin succeeds because it constructs and passes in a sink, where the plugin:report execution fails. That's just a theory.
Hide
John Casey added a comment -

Made a copy of the 2.0.4 tag for maven-reporting-impl to https://svn.apache.org/repos/asf/maven/shared/branches/maven-reporting-impl-2.0.4.1-dev, then adjusted the AbstractMavenReport and SinkFactory to avoid using the Renderer interface for creating Sink instances. Also bumped the doxia dependencies there to 1.0-alpha-10 to keep up with things. The new version is current 2.0.4.1-SNAPSHOT.

Finally, I bumped the maven-reporting-impl version from 2.0.4 to 2.0.4.1-SNAPSHOT to take advantage of the fixes to AbstractMavenReport.

Show
John Casey added a comment - Made a copy of the 2.0.4 tag for maven-reporting-impl to https://svn.apache.org/repos/asf/maven/shared/branches/maven-reporting-impl-2.0.4.1-dev, then adjusted the AbstractMavenReport and SinkFactory to avoid using the Renderer interface for creating Sink instances. Also bumped the doxia dependencies there to 1.0-alpha-10 to keep up with things. The new version is current 2.0.4.1-SNAPSHOT. Finally, I bumped the maven-reporting-impl version from 2.0.4 to 2.0.4.1-SNAPSHOT to take advantage of the fixes to AbstractMavenReport.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: