Maven 2.x Plugin Tools

Allow customization of file encoding used for generated help goal

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.4
  • Fix Version/s: 2.5
  • Component/s: API, Plugin Plugin
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

If the executing JVM runs using file.encoding = ISO-8859-1 but the project source code is expected to be encoded in UTF-8, the generated help goal will mess up non-ascii characters. To smoothly integrate into the build, the mojo needs a parameter to configure the desired encoding.

  1. Text File
    help-goal-encoding.patch
    18/Mar/08 7:08 AM
    3 kB
    Benjamin Bentmann
  2. Text File
    help-goal-encoding.patch
    14/Mar/08 5:43 PM
    3 kB
    Benjamin Bentmann

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. MNG-2216 Add default encodings section to POM

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Improvement - An improvement or enhancement to an existing feature or task. MPLUGIN-101 Allow customization of file encoding used for mojo extraction

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Benjamin Bentmann added a comment -

Moved mojo parameter "encoding" up to AbstractGeneratorMojo for re-usage by mojo scanner with regard to MPLUGIN-101.

Show
Benjamin Bentmann added a comment - Moved mojo parameter "encoding" up to AbstractGeneratorMojo for re-usage by mojo scanner with regard to MPLUGIN-101 .
Hide
Permalink
Benjamin Bentmann added a comment -

The default encoding needs to be kept at platform encoding.

Show
Benjamin Bentmann added a comment - The default encoding needs to be kept at platform encoding.
Hide
Permalink
John Casey added a comment -

Passing PluginToolsRequest into Generator implementations now, so they can have access to project, pluginDescriptor, encoding, etc. all in one.

Show
John Casey added a comment - Passing PluginToolsRequest into Generator implementations now, so they can have access to project, pluginDescriptor, encoding, etc. all in one.

People

  • Assignee:
    John Casey
    Reporter:
    Benjamin Bentmann
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: