Maven Plugin Tools
  1. Maven Plugin Tools
  2. MPLUGIN-100

Allow customization of file encoding used for generated help goal

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.5
    • Component/s: API, Plugin Plugin
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      If the executing JVM runs using file.encoding = ISO-8859-1 but the project source code is expected to be encoded in UTF-8, the generated help goal will mess up non-ascii characters. To smoothly integrate into the build, the mojo needs a parameter to configure the desired encoding.

      1. help-goal-encoding.patch
        3 kB
        Benjamin Bentmann
      2. help-goal-encoding.patch
        3 kB
        Benjamin Bentmann

        Issue Links

          Activity

          Hide
          Benjamin Bentmann added a comment -

          Moved mojo parameter "encoding" up to AbstractGeneratorMojo for re-usage by mojo scanner with regard to MPLUGIN-101.

          Show
          Benjamin Bentmann added a comment - Moved mojo parameter "encoding" up to AbstractGeneratorMojo for re-usage by mojo scanner with regard to MPLUGIN-101 .
          Hide
          Benjamin Bentmann added a comment -

          The default encoding needs to be kept at platform encoding.

          Show
          Benjamin Bentmann added a comment - The default encoding needs to be kept at platform encoding.
          Hide
          John Casey added a comment -

          Passing PluginToolsRequest into Generator implementations now, so they can have access to project, pluginDescriptor, encoding, etc. all in one.

          Show
          John Casey added a comment - Passing PluginToolsRequest into Generator implementations now, so they can have access to project, pluginDescriptor, encoding, etc. all in one.

            People

            • Assignee:
              John Casey
              Reporter:
              Benjamin Bentmann
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: