Issue Details (XML | Word | Printable)

Key: MPLINKCHECK-10
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Arnaud Heritier
Reporter: Kees Jongenburger
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven 1.x LinkCheck Plugin

allo 303 and 304 http status to be validated

Created: 15/Mar/04 06:55 PM   Updated: 13/Jan/06 07:00 PM   Resolved: 13/Jan/06 07:00 PM
Component/s: None
Affects Version/s: None
Fix Version/s: 1.4

Time Tracking:
Original Estimate: 10 minutes
Original Estimate - 10 minutes
Remaining Estimate: 10 minutes
Remaining Estimate - 10 minutes
Time Spent: Not Specified
Time Spent - Not Specified

Environment: maven rc2


 Description  « Hide

The linkchecker flows MOVED_TEMPORARILY moved links but sikps MOVED_PERMANENTLY while there are as valid as MOVED_TEMPORARILY

example:
http://www.mmbase.org/license

resolution:
add
import org.apache.commons.httpclient.HttpStatus;
to the class imports

in HTTPLinkValidator at row 108 change the code to
if (gm.getStatusCode() == HttpStatus.SC_MOVED_TEMPORARILY || gm.getStatusCode() == HttpStatus.SC_MOVED_PERMANENTLY)

(and a small cleanup )
row 121
if (gm.getStatusCode() == HttpStatus.SC_OK)



Carlos Sanchez added a comment - 01/Aug/04 05:16 PM

IMHO is better to report MOVED PERMANENTLY as errors so the user can change the links.


Kees Jongenburger added a comment - 02/Aug/04 03:05 AM

I partialy agree. following moved_permanently should not be automatic
Still it's a valid url


Arnaud Heritier added a comment - 13/Jan/06 07:00 PM

Fixed with MPLINKCHECK-25