Maven 1.x Jetty Plugin

Cannot compile jsp pages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Labels:
    None
  • Number of attachments :
    2

Description

tools.jar missing from plugin classpath -> cannot compile jsp pages

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Ryan added a comment -

this patch for the jetty maven plugin allows for jsp compilation. tools.jar is added to the classpath and because of some dependency ant.jar as well.

this patch was created from cvs head on 12-22-2004

Show
Peter Ryan added a comment - this patch for the jetty maven plugin allows for jsp compilation. tools.jar is added to the classpath and because of some dependency ant.jar as well. this patch was created from cvs head on 12-22-2004
Hide
Permalink
Peter Ryan added a comment -

this is a precompiled version of the modifed jetty plugin. replace this file with the 1.1 version in maven/plugins

Show
Peter Ryan added a comment - this is a precompiled version of the modifed jetty plugin. replace this file with the 1.1 version in maven/plugins
Hide
Permalink
Vincent Massol added a comment -

Hi Peter,

I was looking into applying your patch but I'm confused. Your latest comment suggest to use some jar containing source files. However, in order to apply your pach I would need the changes in pach format (diff -u).

Thanks a lot

Show
Vincent Massol added a comment - Hi Peter, I was looking into applying your patch but I'm confused. Your latest comment suggest to use some jar containing source files. However, in order to apply your pach I would need the changes in pach format (diff -u). Thanks a lot
Hide
Permalink
Peter Ryan added a comment -

There are two attachments.

#1 The patch file for the changes to allow jsp compilation.

#2 A compiled version of the plugin in case someone experienced the bug and wanted to simply wanted to replace the jetty plugin in their maven installation.

Peter

PS I noticed in the patch that I forgot to remove an unnecessary echo statement. After you apply the patch please remove the line which was used for testing:

<echo message="$

{tools.jar}

"/>

Show
Peter Ryan added a comment - There are two attachments. #1 The patch file for the changes to allow jsp compilation. #2 A compiled version of the plugin in case someone experienced the bug and wanted to simply wanted to replace the jetty plugin in their maven installation. Peter PS I noticed in the patch that I forgot to remove an unnecessary echo statement. After you apply the patch please remove the line which was used for testing: <echo message="$ {tools.jar} "/>
Hide
Permalink
Vincent Massol added a comment -

Ok, got it. Thanks Peter.

Just a question. Where do you get the $

{tools.jar}

value from (who sets it)?

Show
Vincent Massol added a comment - Ok, got it. Thanks Peter. Just a question. Where do you get the $ {tools.jar} value from (who sets it)?
Hide
Permalink
dion gillard added a comment -

tools.jar is set in maven's bat/shell script

Show
dion gillard added a comment - tools.jar is set in maven's bat/shell script
Hide
Permalink
Juan F. Codagnone added a comment -

i just reach to the same solution. Others plugins uses $

{tools.jar}

juan@dinah jetty $ find ~/.maven/cache/|xargs grep tools.jar
/home/juan/.maven/cache/maven-dotuml-plugin-1.0/plugin.jelly: <ant:path location="${tools.jar}

"/>
/home/juan/.maven/cache/maven-dotuml-plugin-1.0-java5-zauber/plugin.jelly: <ant:path location="$

{tools.jar}"/>
/home/juan/.maven/cache/maven-jellydoc-plugin-1.3.1/project.properties:maven.jar.javadoc=${tools.jar}
Show
Juan F. Codagnone added a comment - i just reach to the same solution. Others plugins uses $ {tools.jar} juan@dinah jetty $ find ~/.maven/cache/|xargs grep tools.jar /home/juan/.maven/cache/maven-dotuml-plugin-1.0/plugin.jelly: <ant:path location="${tools.jar} "/> /home/juan/.maven/cache/maven-dotuml-plugin-1.0-java5-zauber/plugin.jelly: <ant:path location="$ {tools.jar}"/> /home/juan/.maven/cache/maven-jellydoc-plugin-1.3.1/project.properties:maven.jar.javadoc=${tools.jar}
Hide
Permalink
Vincent Massol added a comment -

Applied (at last!). Sorry for the delay...

Show
Vincent Massol added a comment - Applied (at last!). Sorry for the delay...

People

  • Assignee:
    Vincent Massol
    Reporter:
    Janne Kario
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: