Maven 1.x JCoverage Plugin

maven.jcoverage.instrumentation.excludes does not work

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.0.9
  • Fix Version/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Setting the instrumentation excludes causes jcoverage to fail with classes not found exceptions.

To correct, change the following in plugin.jelly from

<ant:copy todir="$

{maven.jcoverage.instrumentation}">
<ant:fileset dir="${maven.build.dest}">
<ant:exclude name="*/.class" />
<ant:exclude name="${maven.jcoverage.instrumentation.excludes}" />
</ant:fileset>
</ant:copy>

to

<ant:copy todir="${maven.jcoverage.instrumentation}

">
<ant:fileset dir="$

{maven.build.dest}

">
<ant:exclude name="*/.class" />
<ant:include name="$

{maven.jcoverage.instrumentation.excludes}

" />
</ant:fileset>
</ant:copy>

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
thierry lach added a comment -

My suggested correction appears to be premature and does not work.

Show
thierry lach added a comment - My suggested correction appears to be premature and does not work.
Hide
Permalink
Eric Ballet Baz added a comment -

I think you have to split the copy operation into 2 steps :

<ant:copy todir="$

{maven.jcoverage.instrumentation}">
<ant:fileset dir="${maven.build.dest}">
<ant:include name="${maven.jcoverage.instrumentation.excludes}" />
</ant:fileset>
</ant:copy>

<ant:copy todir="${maven.jcoverage.instrumentation}

">
<ant:fileset dir="$

{maven.build.dest}

">
<ant:exclude name="*/.class" />
<ant:exclude name="$

{maven.jcoverage.instrumentation.excludes}

" />
</ant:fileset>
</ant:copy>

Eric Ballet Baz

Show
Eric Ballet Baz added a comment - I think you have to split the copy operation into 2 steps : <ant:copy todir="$ {maven.jcoverage.instrumentation}"> <ant:fileset dir="${maven.build.dest}"> <ant:include name="${maven.jcoverage.instrumentation.excludes}" /> </ant:fileset> </ant:copy> <ant:copy todir="${maven.jcoverage.instrumentation} "> <ant:fileset dir="$ {maven.build.dest} "> <ant:exclude name="* / .class" /> <ant:exclude name="$ {maven.jcoverage.instrumentation.excludes} " /> </ant:fileset> </ant:copy> Eric Ballet Baz
Hide
Permalink
Eric Ballet Baz added a comment -

In fact, this is more correct, since it allows multiple patterns in maven.jcoverage.instrumentation.excludes

<ant:copy todir="$

{maven.jcoverage.instrumentation}">
<ant:fileset dir="${maven.build.dest}"
includes="${maven.jcoverage.instrumentation.excludes}">
</ant:fileset>
</ant:copy>

<ant:copy todir="${maven.jcoverage.instrumentation}

">
<ant:fileset dir="$

{maven.build.dest}

"
excludes="$

{maven.jcoverage.instrumentation.excludes}

">
<ant:exclude name="*/.class" />
</ant:fileset>
</ant:copy>

Is there some plan to include this in the next release ?

Thanks
Eric Ballet-Baz

Show
Eric Ballet Baz added a comment - In fact, this is more correct, since it allows multiple patterns in maven.jcoverage.instrumentation.excludes <ant:copy todir="$ {maven.jcoverage.instrumentation}"> <ant:fileset dir="${maven.build.dest}" includes="${maven.jcoverage.instrumentation.excludes}"> </ant:fileset> </ant:copy> <ant:copy todir="${maven.jcoverage.instrumentation} "> <ant:fileset dir="$ {maven.build.dest} " excludes="$ {maven.jcoverage.instrumentation.excludes} "> <ant:exclude name="* / .class" /> </ant:fileset> </ant:copy> Is there some plan to include this in the next release ? Thanks Eric Ballet-Baz

People

  • Assignee:
    Unassigned
    Reporter:
    thierry lach
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: