Generate WAR/EJB modules in project file

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.4
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    JBX, WinXP

Description

Hi I have a patch that can generate WAR and EJB modules for project file. But I only tested the patch on JBX. Can someone test the patch on older versions of JB?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emmanuel Venisse added a comment -

Can attach your patch?
Thanks.

Show
Emmanuel Venisse added a comment - Can attach your patch? Thanks.
Hide
Permalink
Dan Tran added a comment -

I am having 2 problems that I need some advice here:

1. My code currently calls attainGoal on ejb:init and war:load
in order for me to retrieve ejb and war's properties.
ejb:init trigger the probject to build which I dont really
like.

Is there a way to retreive ejb and war properties differently?

2. JBuilderX changes format from 9 to X, so my generated code
only works with X version. It it ok?

Please advice

-Dan

Show
Dan Tran added a comment - I am having 2 problems that I need some advice here: 1. My code currently calls attainGoal on ejb:init and war:load in order for me to retrieve ejb and war's properties. ejb:init trigger the probject to build which I dont really like. Is there a way to retreive ejb and war properties differently? 2. JBuilderX changes format from 9 to X, so my generated code only works with X version. It it ok? Please advice -Dan
Hide
Permalink
Emmanuel Venisse added a comment -

1. You can use the get tag from maven tag library
<maven:get var="..." plugin="..." property="..."/>
available with rc3.

2. It's not a problem if it's in a specific goal.

Show
Emmanuel Venisse added a comment - 1. You can use the get tag from maven tag library <maven:get var="..." plugin="..." property="..."/> available with rc3. 2. It's not a problem if it's in a specific goal.
Hide
Permalink
Dan Tran added a comment -

OK, now that I got approval to fix this only for JBX and above.
So here is how I implemented:

  • I will only generate EJB and Web Module if the targeted
    JB is jbuilderX and above
  • I only generate Web module if I detect the present of
    ${maven.war.src}/WEB-INF/web.xml
  • I only generate EJB module if I detect the present of
    ${maven.ejb.src}/META-INF/ejb-jar.xml
  • User will need to manually attached application server
    under test to the module using jbuilder. Too much work
    to hander that since It has too many combination to test.

Do they sound acceptable?

Regarding the use of maven:get in RC3. I dont think i can use it.
I need to have access to maven.war.final.name and maven.ejb.final.name. These 2 vars only configure in war:init
and ejb:init respectively.

So there are 2 solutions for this:

1. Not use maven.xxx.final.name at all
use use the combination of pom.artifactId and pom.currentVersion

2. Use ejb:init and war:init any way since
user needs clean up compilation error any way.

finally, i dont think I can create a separate goal, it would requires lots of work. A huge refractoring in the plugin.jell.
For now an if statement would be ok.

Any thought?

-Dan

Show
Dan Tran added a comment - OK, now that I got approval to fix this only for JBX and above. So here is how I implemented:
  • I will only generate EJB and Web Module if the targeted JB is jbuilderX and above
  • I only generate Web module if I detect the present of ${maven.war.src}/WEB-INF/web.xml
  • I only generate EJB module if I detect the present of ${maven.ejb.src}/META-INF/ejb-jar.xml
  • User will need to manually attached application server under test to the module using jbuilder. Too much work to hander that since It has too many combination to test.
Do they sound acceptable? Regarding the use of maven:get in RC3. I dont think i can use it. I need to have access to maven.war.final.name and maven.ejb.final.name. These 2 vars only configure in war:init and ejb:init respectively. So there are 2 solutions for this: 1. Not use maven.xxx.final.name at all use use the combination of pom.artifactId and pom.currentVersion 2. Use ejb:init and war:init any way since user needs clean up compilation error any way. finally, i dont think I can create a separate goal, it would requires lots of work. A huge refractoring in the plugin.jell. For now an if statement would be ok. Any thought? -Dan
Hide
Permalink
Emmanuel Venisse added a comment -

> Do they sound acceptable?
Yes.

> So there are 2 solutions for this:
>
> 1. Not use maven.xxx.final.name at all
> use use the combination of pom.artifactId and
> pom.currentVersion
>
> 2. Use ejb:init and war:init any way since
> user needs clean up compilation error any way.

2. We must use the same mechanism like ejb and war plugins.

> For now an if statement would be ok.
OK.

Show
Emmanuel Venisse added a comment - > Do they sound acceptable? Yes. > So there are 2 solutions for this: > > 1. Not use maven.xxx.final.name at all > use use the combination of pom.artifactId and > pom.currentVersion > > 2. Use ejb:init and war:init any way since > user needs clean up compilation error any way. 2. We must use the same mechanism like ejb and war plugins. > For now an if statement would be ok. OK.
Hide
Permalink
Dan Tran added a comment -

Good, let me do more testing and send in the patch.

Question: where should I document the part where user needs to
manually attach an appserver under test to the module? and the
jbuiderX specific.

Goal.xml?

Show
Dan Tran added a comment - Good, let me do more testing and send in the patch. Question: where should I document the part where user needs to manually attach an appserver under test to the module? and the jbuiderX specific. Goal.xml?

People

  • Assignee:
    Unassigned
    Reporter:
    Dan Tran
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: