needed check incorrect

The javadoc plugin has undergone some changes adding support for iterating across the directories in the maven.compile.src.set path ref. However, there is an error in the check:needed logic.

Line numbers below are against this version of the plugin:

http://cvs.apache.org/viewcvs.cgi/maven-plugins/javadoc/plugin.jelly?rev=1.42&view=markup

The foreach loop at line 99 iterates across the directories in the maven.compile.src.set. The test at line 101 reads:

<j:if test="$

">

If there are two directories in maven.compile.src.set, and the first directory has no source files in it, then the first iteration of this loop will leave needed equal to false. The second time through the loop, since needed is no longer equal to null, the loop is short circuited, and, because needed is false, no processing is done, even though there may be valid source files in the second directory.

Changing the test on line 101 to:

<j:if test="$

">

will correct this problem, short circuiting the loop only after the first directory with valid source files is found.

Denis