Maven 1.x Jar Plugin

Maybe I'm missing something, but I don't see anywhere in the maven core (including core-bundled plugins) where pom.specificationVersion is set. To prove this to myself, I created a jar of one of my commonjava projects, then checked the MANIFEST.MF. This is what I got:

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3
Created-By: Apache Jakarta Maven
Built-By: jdcasey
Package: org.commonjava.io
Build-Jdk: 1.4.2_01
Extension-Name: commonjava-io

Specification-Version:
^^^^^^^^^^^^^^

Specification-Vendor: CommonJava Open Component Project
Specification-Title:
Implementation-Version: 2.0
Implementation-Vendor: CommonJava Open Component Project
Implementation-Vendor-Id:

As you can see, nothing! Maybe we should be setting Specification-Version to ${pom.currentVersion} everywhere...

I've fixed the jar plugins use of pom.specificationVersion.
It now uses pom.currentVersion

jar plugin uses:

<ant:attribute name="Implementation-Vendor"
value="${pom.organization.name}"/>

which looks ok

Setting the project properties works fine for the declaration of the spec-version and vendor-id.

Example:

<ant:property name="pom.organization.identifier" value="ASF"/>
<ant:property name="pom.specificationVersion" value="1.2"/>

Should we go ahead and fix the rest of the attributes in these two plugins? We could specify the following in the jar plugin:

Specification-Title: ${pom.shortDescription}
Implementation-Vendor-Id: ${pom.groupId}
Implementation-Title: ${pom.shortDescription}

Then, we could simply copy the <ant:artifact>...</ant:artifact> element structure to the ejb plugin...I'm willing to submit this as a patch, just want a go-ahead to do it.

A patch would be great

My impression is that the maven.ejb.plugin assignment of pom.currentVersion to Specification-Version is a bug. A spec version is not the same as an impl version.

If you submitting a patch that references the POM short description - can you please check for trimming of the value to a single line. Currently something like the following will cause runtime error as the pom value is not returning a trimmed single line value.

<shortDescrption>
My short description.
</shortDescription>

Okay, so in the EJB manifest, should the Specification-* attributes refer to the EJB spec? If so, can we hard-code the specification vendor and title as SUN and EJB/J2EE, etc.?

I believe the EJB jar manifest should document the specification and implementation of the application not that of EJB/J2EE. EJB information is available separately in EJB-specific files (via DTDs in XML).

Under Maven RC2 the jar plugin manifest entries have been changed in such a way that can result in runtime failure based on the assigned specification version.

The change is the inclusion of the following line in the manifest:

<ant:attribute name="Specification-Version" value="${pom.currentVersion}"/>

Firstly - the "Specification-Version" is not the same as the implementation version (impl version is correctly assigned as ${pom.currentVersion). Secondly the jar optional extensions spec requires that the specification version is a dewey decimal. RC2 generated jars will fail if the current version of the jar contains alphanumeric characters (e.g. 1.2-dev) or any string value that cannot be converted to a dewey decimal.

commented out offending entries. Will raise a new issue to correct the assignment of certain pom variables to Specification/Implementation-*