REDUX: Specification-Version and Implementation-Vendor-Id not being set

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Duplicate
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None

Description

http://jira.codehaus.org/browse/MPJAR-7?rc=1 commented out code to set the Specification-Version manifect attribute. There seems to have been quite a bit of debate about that bug. The result seems to be that the code was commented out http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/jar/plugin.jelly?rev=115072&r1=115041&r2=115072&diff_format=h so that the RC3 could ship and a more permenent solution found later. It's still there.

Specification-Version should really be set for libraries: IIRC there are some fancy EJB library loading routines which rely on it. Personally speaking, I'd be happen to uncomment the commented line.

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. MPJAR-39 Support specificationVersion in manifest

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. MJAR-5 no Implementation-Vendor-Id in META-INF/MANIFEST.MF

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joerg Schaible added a comment -

Problem is, that the manifest spec does only allow number values for the specification version entry. So that entry should not have a version that ends e.g. with -SNAPSHOT. I solved this in the javaapp plugin by extracting major.minor from the version unless it is overwritten with a property (http://maven-plugins.sourceforge.net/maven-javaapp-plugin/properties.html).

Show
Joerg Schaible added a comment - Problem is, that the manifest spec does only allow number values for the specification version entry. So that entry should not have a version that ends e.g. with -SNAPSHOT. I solved this in the javaapp plugin by extracting major.minor from the version unless it is overwritten with a property (http://maven-plugins.sourceforge.net/maven-javaapp-plugin/properties.html).
Hide
Permalink
Robert Burrell Donkin added a comment -

+1

using major.minor is just what we need for the commons.

later versions of the jar specification (http://java.sun.com/j2se/1.5.0/docs/guide/extensions/versioning.html) mean that we really need the implementation-vendor-id set as well. i wonder whether basising this on the organization url (http://www.apache.org -> org.apache) might be about right.

Show
Robert Burrell Donkin added a comment - +1 using major.minor is just what we need for the commons. later versions of the jar specification (http://java.sun.com/j2se/1.5.0/docs/guide/extensions/versioning.html) mean that we really need the implementation-vendor-id set as well. i wonder whether basising this on the organization url (http://www.apache.org -> org.apache) might be about right.
Hide
Permalink
Carlos Sanchez added a comment -

Dupe of MPJAR-39

Show
Carlos Sanchez added a comment - Dupe of MPJAR-39

People

  • Assignee:
    Carlos Sanchez
    Reporter:
    Robert Burrell Donkin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: